Removing unused/mislabeled flow rate fields in GroundHeatExchanger:Vertical

[mitchute]

While working on the NFP for the slinky GHX model, I found that the current GHX model has one field that is mislabeled and another which is not used. The max flow rate variable here: https://github.com/NREL/EnergyPlus/blob/develop/src/EnergyPlus/GroundHeatExchangers.cc#L765, is not used and the design flow rate, here; https://github.com/NREL/EnergyPlus/blob/develop/src/EnergyPlus/GroundHeatExchangers.cc#L756, is labled as the max flow rate in the idd.

[mitchute]

@Myoldmopar I think I have this issue cleaned up here: c0e3ded. I didn't see any diffs on my machine. We'll see what CI comes back with.

[mjwitte]

@mmAtTs Can this issue be closed?

[mitchute]

@mjwitte Yes.

[shorowit]

FYI, the Rules8-2-0-to-8-3-0.xls transition program also has a bug related to this issue. The transition program removes the "Design Flow Rate" field, whereas best I can tell from looking at the 8.3 IDD, the "Maximum Flow Rate" field was removed and the "Design Flow Rate" field was moved to the location of where the "Maximum Flow Rate" field was.

Anyway, not sure if the E+ team cares about fixing old transition programs but wanted to make the issue known.

[mjwitte]

@mmAtTs Please confirm if this is a real issue. If so, should open a new one.

[mitchute]

Looks like there are some errors in it. I'll open a new issue.