Crash with schedule with missing day types

[mjwitte]

Issue overview

Schedule with missing day types generates warning in v24.2, crashes in v25.1.

  Schedule:Compact,
    WindowVentSched,         !- Name
    Any Number,              !- Schedule Type Limits Name
    Through: 12/31,          !- Field 1
    For: Monday Tuesday Wednesday Thursday Friday Saturday, !- Field 2
    Until: 8:30,0,           !- Field 3
    Until: 11:30,1,          !- Field 5
    Until: 12:00,0,          !- Field 7
    Until: 13:00,1,          !- Field 9
    Until: 19:00,0,          !- Field 11
    Until: 20:00,1,          !- Field 13
    Until: 24:00,0;          !- Field 15


Program Version,EnergyPlus, Version 24.2.0-94a887817b, YMD=2025.05.13 12:58,

   ** Warning ** ProcessScheduleInput: Schedule:Compact="WINDOWVENTSCHED" has missing day types in Through=12/31
   **   ~~~   ** Last "For" field=FOR: MONDAY TUESDAY WEDNESDAY THURSDAY FRIDAY SATURDAY
   **   ~~~   ** Missing day types="Sunday","Holiday","SummerDesignDay","WinterDesignDay","CustomDay1","CustomDay2"
   **   ~~~   ** Missing day types will have 0.0 as Schedule Values

Adding this to the schedule object fixes the crash:

    For: AllOtherDays, Until: 24:00, 0;

Operating System (Multiple choices)

Any

Operating System Version

any

Version of EnergyPlus

25.1

Unmethours link or helpdesk ticket number

Helpdesk ticket 16894

Defect file

EnergyPlusDevSupport\DefectFiles\

[amirroth]

Oh what a tangled web we weave when first we practice to object-orient a thirty-year old module.

I agree that a crash is not the right behavior, but what is the right behavior? Should this be made into a severe/fatal error and ask the user to supply an AllOtherDays line? Should we maintain the 24.2 behavior of printing a warning and using a 0.0 for all non-specified days? I am not a huge fan of defaults that are only documented via warnings or really of defaults at all but if making this into an error is going to cause serious problems ...

[mjwitte]

I would say "maintain the 24.2 behavior of printing a warning and using a 0.0 for all non-specified days".

[jmarrec]

@amirroth can I take this out or do you feel an urge to fix all the schedule API refactor-related issues?

The fix is dead simple, but it's a matter of writing a unit test.

[amirroth]

Please take it. I am underwater.