Add UTF-8 support

[keytrap-x86]

Hi,

is there any way of adding a UTF-8 support ? I live in france and we have a lot of accents in our words, so even when I run a "ipconfig/route print", if my network card contains accents it doesn't show up correctly :

[wlscaudill]

@varKeytrap I was under the impression this supported UTF-8. I'm happy to make any adjustments needed for this to work. Please specify exactly how you're using the code and where the error is from so I can reproduce it on my end. Thank you.

[keytrap-x86]

@wlscaudill Here's the code I'm using :

using Naos.WinRM;

...

var machineManager = new MachineManager("computer", @"user", "password".ToSecureString(), autoManageTrustedHosts: true);
var output = machineManager.RunCmd("ipconfig");
Textbox1.Text = output;

This is what was expected :

Carte Ethernet Ethernet :

   Suffixe DNS propre à la connexion. . . : domain.local
   Adresse IPv4. . . . . . . . . . . . . .: 192.1.2.158
   Masque de sous-réseau. . . . . . . . . : 255.255.255.0
   Passerelle par défaut. . . . . . . . . : 192.1.2.252

Carte inconnue Connexion au réseau local :

   Statut du média. . . . . . . . . . . . : Média déconnecté
   Suffixe DNS propre à la connexion. . . :

Carte réseau sans fil Wi-Fi :

   Statut du média. . . . . . . . . . . . : Média déconnecté
   Suffixe DNS propre à la connexion. . . : domain.local

Carte réseau sans fil Connexion au réseau local* 11 :

   Statut du média. . . . . . . . . . . . : Média déconnecté
   Suffixe DNS propre à la connexion. . . :

Carte réseau sans fil Connexion au réseau local* 12 :

   Statut du média. . . . . . . . . . . . : Média déconnecté
   Suffixe DNS propre à la connexion. . . :

and this is the ouput that I've got :

Carte Ethernet Ethernet :

   Suffixe DNS propre … la connexion. . . : domain.local
   Adresse IPv4. . . . . . . . . . . . . .: 192.1.2.158
   Masque de sous-r‚seau. . . .ÿ. . . . . : 255.255.255.0
   Passerelle par d‚faut. . . .ÿ. . . . . : 192.1.2.252

Carte inconnue Connexion au r‚seau localÿ:

   Statut du m‚dia. . . . . . . . . . . . : M‚dia d‚connect‚
   Suffixe DNS propre … la connexion. . . : 

Carte r‚seau sans fil Wi-Fiÿ:

   Statut du m‚dia. . . . . . . . . . . . : M‚dia d‚connect‚
   Suffixe DNS propre … la connexion. . . : domain.local

Carte r‚seau sans fil Connexion au r‚seau local* 11ÿ:

   Statut du m‚dia. . . . . . . . . . . . : M‚dia d‚connect‚
   Suffixe DNS propre … la connexion. . . : 

Carte r‚seau sans fil Connexion au r‚seau local* 12ÿ:

   Statut du m‚dia. . . . . . . . . . . . : M‚dia d‚connect‚
   Suffixe DNS propre … la connexion. . . : 

[wlscaudill]

@varKeytrap I'm looking into this but finding that the Unicode support of this (outside of Powershell Core) is quite fragmented.

https://stackoverflow.com/questions/49476326/displaying-unicode-in-powershell

I'll keep seeing if there is a way for me to manage this through WinRM but I'm not certain at this point.

[keytrap-x86]

@wlscaudill When I run it through "winrs -r:server ipconfig" I don't have the problem...
Btw, which is the new package ?

• Naos.MachineManagement ?
• Naos.WinRM ?

[wlscaudill]

@varKeytrap that's good to know. WinRS is running through PowerShell instead of CMD so you might want to try running:

var output = machineManager.RunScript("{ ipconfig }");

This will run the command inside a script block and be all PowerShell...

I forgot the relationship previously; Naos.WinRM has the recipe package id=Naos.Recipes.WinRM which will install the CS file (or you can copy it by hand). Naos.MachineManagement has an assembly package id=Naos.MachineManagement.WinRm which wraps the recipe from Naos.WinRM behind and interface that can be swapped out for other machinemanagers like SSH (although I'm still working on the SSH implementation and should have it out soon-ish). So they use the same code path and if you just want the CS file or you're copying from GitHub by hand then you're better off going straight to Naos.WinRM. If you're going to be hitting several machines and some of them might be Linux then you're probably better off coding against the interface in package id=Naos.MachineManagement.Domain and using the implementations in the package assemblies.

I hope that all makes sense, let me know if you have any questions around the organization and whether using the scriptblock version instead of CMD.exe version fixes your unicode issue.

Cheers

[keytrap-x86]

@wlscaudill Thanks for you complete answer. Unfortunately, even with machineManager.RunScript("{ ipconfig }"); it's still the same

[wlscaudill]

@varKeytrap Thank you for testing that, I think I've found a way to do this but I don't love it. I'm going to keep looking for a better way to set this up for you. In the meantime could you please try running this:

machineManager.RunScript("{ [Console]::OutputEncoding = [System.Text.Encoding]::UTF8; ipconfig }");

Let me know if that works for you and I'll update if I can find a better way to set that.

[wlscaudill]

@varKeytrap Is this still an issue, I would like to know if the outputEncoding being set was sufficient or not.

[keytrap-x86]

@wlscaudill Sorry for late response, It didn't work..

[keytrap-x86]

Btw I've seen this today, which made me think of our discussion

(Check the comments in NetshellCmd)

[keytrap-x86]

@wlscaudill Ok I have found the final solution (native) :

var pi = new ProcessStartInfo("cmd", "/c ipconfig /all")
{
    StandardOutputEncoding = Encoding.GetEncoding("cp437")
};