fix: remove incorrect ConstantThreshold from UnivariateDriftCalculator #425
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r docstring Updated the UnivariateDriftCalculator docstring by removing ConstantThreshold(upper=0.1) as it incorrectly reflects the default behavior. The correct default is StandardDeviationThreshold(std_lower_multiplier=None).
nnansters
approved these changes
Sep 25, 2024
Contributor
Author
|
@nnansters will this PR be reflected in the next release? |
Contributor
|
Yup! Not sure when it will be out, but it will be included, with a nice shout-out of course. Need it released urgently? |
Contributor
Author
No need for urgent update. I was curious about further releases |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
updated docstring
Updated the UnivariateDriftCalculator docstring by removing ConstantThreshold(upper=0.1) as it incorrectly reflects the default behavior. The correct default is StandardDeviationThreshold(std_lower_multiplier=None).