Feature/update messages#6
Merged
Merged
Conversation
名称の変更 - `Req` -> `Request` - `Res` -> `Response` `Response` - `isConnectionReusable` 接続の再利用の可否 - `isSuccess` 要求の成功
Responseを変更して外部インターフェースが変わってもテストが通ってしまっていたので
声質 -> 声種
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
メッセージの形式を変更した
Before
エラーが発生した場合に、次のリクエストが受付可能かがわからなかった。
After
isConnectionReusableを追加し、現在の接続が使用可能かを応答に含める。requestを追加し、現在の応答がどのリクエストに対するものかを明確にする。