Skip to content

Conversation

@Hitdahit
Copy link

@Hitdahit Hitdahit commented May 6, 2025

Problem Statement

  • DAM repository supports selective SAM2 build during DAM installation.
    • by pip install -e ".[sam2]"
  • But we need SAM2 config file and weight file to use SAM2 which is not automatically fetched by their installation.
  • Also there is typo error in pyproject.toml related to SAM2.

Solution

  • Edited pyproject.toml's typo error and added SAM2 (sam2.1_hiera_large) config file
  • Also added SAM2 (sam2.1_hiera_large) weight fetching script named get_sam2_weight.sh
  • By these changes, you can install and use DAM with SAM2 without any errors.

Installation Guide should be changed like this.

  1. git clone && cd
  2. execute get_sam2_weight.sh
  3. pip install -e ".[sam2]"

@Hitdahit Hitdahit changed the title sam2 weight, config 파일 제공 및 sam2 관련 toml 수정 Adding sam2 weight fetcher, config file and pypoject.toml typo error fixing May 6, 2025
@TonyLianLong
Copy link
Collaborator

Thanks for the PR. I fixed the typo in pyproject.toml and added instructions to let the user install SAM 2 first.

@Hitdahit
Copy link
Author

Hitdahit commented May 6, 2025

Thank you for fast reaction. Byt the way, do you have any plan to open DLC-SDP or train/finetune code in this repository?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants