Skip to content

Remove interp from primvar descriptor equality check #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: dev
Choose a base branch
from
Open

Remove interp from primvar descriptor equality check #6

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b7fc427
Remove interp from primvar descriptor equality
tylerm-nv Nov 14, 2022
26002c7
feedback
tylerm-nv May 11, 2023
45e4a99
revert scenedelegate
tylerm-nv May 11, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions pxr/imaging/hd/sceneDelegate.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -191,8 +191,7 @@ struct HdPrimvarDescriptor {
: name(name_), interpolation(interp_), role(role_), indexed(indexed_)
{ }
bool operator==(HdPrimvarDescriptor const& rhs) const {
Copy link
Collaborator

@asluk asluk Nov 15, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we'll want to add a test, similar to what @nvidia-jomiller did in PixarAnimationStudios#1807, that fails without the change, and passes with it. Thanks!

return name == rhs.name && role == rhs.role
&& interpolation == rhs.interpolation;
return name == rhs.name && role == rhs.role;
}
bool operator!=(HdPrimvarDescriptor const& rhs) const {
return !(*this == rhs);
Expand Down