Fix failing Johns Hopkins Turbulence DB calls by upgrading pyJHTDB to giverny #275
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PhysicsNeMo Pull Request
Description
Hi team!
I am a PhD student with the Johns Hopkins Turbulence Database team, whose data you use for your Turbulence Superresolution example (
examples/super_resolution.py).Due to our backend changes, API calls using the deprecated
pyJHTDBlibrary which your code is using return Error 308. Dataset download fails, and so does the whole pipeline. I did not find an existing Issue on this, so I created one 271We discussed this issue with Mike O'Keefe ([email protected]) and Jeffrey Lancaster ([email protected]) and I, on behalf of the JHTDB team, came up with this solution.
This PR provides the upgrade to the new library, called
givernylocal. The code is equivalent to the original pyJHTDB methodChecklist
Dependencies
New dependency: givernylocal
Removed dependency: pyJHTDB