Skip to content

Conversation

@zhanluxianshen
Copy link
Contributor

Fix logger error append logic.

Signed-off-by: zhanluxianshen <[email protected]>
Comment on lines +77 to +79
if err != nil {
argLogFileError = errors.Join(argLogFileError, err)
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you explain why this is required? errors.Join should ignore nil errors.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

// Any nil error values are discarded.
// Join returns nil if every value in errs is nil.
// The error formats as the concatenation of the strings obtained
// by calling the Error method of each element of errs, with a newline
// between each string.
//
// A non-nil error returned by Join implements the Unwrap() []error method.
func Join(errs ...error) error {
	n := 0
	for _, err := range errs {
		if err != nil {
			n++
		}
	}
	if n == 0 {
		return nil
	}
	e := &joinError{
		errs: make([]error, 0, n),
	}
	for _, err := range errs {
		if err != nil {
			e.errs = append(e.errs, err)
		}
	}
	return e
}

@zhanluxianshen
Copy link
Contributor Author

Thanks for quick review.
you are right , its no need to check nil.

@zhanluxianshen zhanluxianshen deleted the fix-logger-err-logic branch November 9, 2024 00:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants