Fix package installation for wheels CI #238
Merged
gmarkall merged 2 commits intoNVIDIA:mainfrom May 3, 2025
Merged
Conversation
Normal wheel tests should not install any CUDA pip packages because they should use the toolkit from the container. The test depending on the toolkit wheels should install the specific toolkit version used for the test (as opposed to just using the latest version, which they were set up to do before).
gmarkall
force-pushed
the
fix-wheels-scripts
branch
from
9db56b1 to
1510c91
Compare
gmarkall
changed the title
gmarkall
added
3 - Ready for Review
gmarkall
commented
May 3, 2025
Contributor
Author
gmarkall
left a comment
gmarkall
left a comment
There was a problem hiding this comment.
As the CI is passing again, and test-wheel-deps-wheels is now getting the toolkit version specified from the environment, I'm going to merge this to proceed with the release.
gmarkall
added
5 - Ready to merge
gmarkall
added a commit
to gmarkall/numba-cuda
that referenced
this pull request
May 3, 2025
- Local variable debug info deduplication (NVIDIA#222) - Fix package installation for wheels CI (NVIDIA#238) - Fix Invalid NVVM IR emitted when lowering shfl_sync APIs (NVIDIA#231) - Add Bfloat16 Low++ Bindings (NVIDIA#166) - Fix cuda.jit decorator inline (NVIDIA#181) - Feature: cuda specific make_attribute_wrapper (NVIDIA#193) - return a none tuple if no libdevice path is found (NVIDIA#234)
Merged
gmarkall
added a commit
that referenced
this pull request
May 3, 2025
- Local variable debug info deduplication (#222) - Fix package installation for wheels CI (#238) - Fix Invalid NVVM IR emitted when lowering shfl_sync APIs (#231) - Add Bfloat16 Low++ Bindings (#166) - Fix cuda.jit decorator inline (#181) - Feature: cuda specific make_attribute_wrapper (#193) - return a none tuple if no libdevice path is found (#234)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Normal wheel tests should not install any CUDA pip packages because they should use the toolkit from the container.
The test depending on the toolkit wheels should install the specific toolkit version used for the test (as opposed to just using the latest version, which they were set up to do before).