generators: check message count requested matches message count generated#1558
Conversation
jmartin-tech
left a comment
There was a problem hiding this comment.
These restrictions seem sensible to me. A minor nit pick added related to error phrasing.
I am not 100% sure however there might be an edge cases where a target might behave irregularly causing this to terminate a run that has already gathered responses for a probe. We can accept this as is and await user feedback on if this ends up being something we should handle more gracefully.
Co-authored-by: Jeffrey Martin <[email protected]> Signed-off-by: Leon Derczynski <[email protected]>
Co-authored-by: Jeffrey Martin <[email protected]> Signed-off-by: Leon Derczynski <[email protected]>
Yeah, this is a risk. I suspect this should be caught at generator level, but let's wait for the signal to emerge first |
Description
OpenAICompatiblemessage count rcvd doesn't match generations requestedprobe()if message count rcvd doesn't match generations requestedOpen to moving checks (maybe
_execute_all?) or adding a hookVerification
Put this lying code in
garak/generators/test.pyand request > 1 generation: