bugfix: TreeSearchProbe should handle Nones #1509
Merged
leondz merged 4 commits intoNVIDIA:mainfrom Dec 4, 2025
Merged
Conversation
leondz
added
bug
erickgalinkin
approved these changes
Dec 2, 2025
Collaborator
erickgalinkin
left a comment
erickgalinkin
left a comment
There was a problem hiding this comment.
Solid, straightforward fix.
| ) | ||
|
|
||
|
|
||
| class Nones(Generator): |
Collaborator
There was a problem hiding this comment.
This feels like something that every probe and detector should have been tested against. Solid add.
jmartin-tech
approved these changes
Dec 3, 2025
jmartin-tech
changed the title
TreeSearchProbe should handle Nones from detectors (and by extension generators)TreeSearchProbe should handle Nones
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #1508
comparison in compilation of node_results only performed over non-
Nonessummary stats calculated after
Nones removedadds a
test.Nonesgenerator for testing this kind of functionalityVerification
without the update in
garak/probes/base.pygarak -t test.Nones -p topic.WordnetControversialfails, yielding the trace in bug: unhandledNoneduring dynamic expansion inTreeProbe#1508with the update in
garak/probes/base.pygarak -t test.Nones -p topic.WordnetControversialsucceed with a SKIP