improve prompt translation support for Conversation related types#1441
Merged
jmartin-tech merged 2 commits intoNVIDIA:mainfrom Oct 28, 2025
Merged
Conversation
* wrap single string in list * extract first result Signed-off-by: Jeffrey Martin <[email protected]>
Collaborator
|
Can we sneak in another related bug fix here? Lines 402-418 also currently assume The correct code snippet needed here is: |
Collaborator
|
oh, nice catch @aishwaryap ! |
* ensure use of a copy of the source prompt * set language on all supported types where needed Signed-off-by: Jeffrey Martin <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Identified by @aishwaryap, when processing prompts of type
MessageorConversationstrict type awareness is required.Verification
List the steps needed to make sure this thing works