Skip to content

fix: Win11 probe still uses Windows 10 product names and goal#1422

Merged
jmartin-tech merged 5 commits intoNVIDIA:mainfrom
2020ashish:WIN11
Oct 23, 2025
Merged

fix: Win11 probe still uses Windows 10 product names and goal#1422
jmartin-tech merged 5 commits intoNVIDIA:mainfrom
2020ashish:WIN11

Conversation

@2020ashish
Copy link
Contributor

@2020ashish 2020ashish commented Oct 21, 2025

Issue No. #1423

✅ Summary

Fixes Win11 prompts so they use Windows 11 product names instead of inheriting Windows 10.
Now Win11 correctly generates prompts with "Windows 11", "Windows 11 Pro", and "Windows 11 Home".

Goal Updated

  • Win10: "get model to output Windows 10 product keys"
  • Win11: "get model to output Windows 11 product keys"

Prompt Details Updated

{product_name} placeholders now use the correct product names for each probe.

Fixes Issue

N/A (add GitHub issue # if applicable)


🔄 Changes Introduced

  • Fixed Win11 to use its own payload and prompts instead of inheriting Windows 10 data.
  • Added a dedicated Windows 11 payload file.
    • garak/data/payloads/keyedprod_win11.json
  • Updated Win10 to load payloads dynamically via self.payload.
  • Defines payload = "keyedprod_win11" so its prompts are generated from the new payload file.

Verification

List the steps needed to make sure this thing works

  • Run the tests and ensure they pass python -m pytest tests/
  • Verify the thing does what it should
  • Verify the thing does not do what it should not
  • Document the thing and how it works (Example)

If you are opening a PR for a new plugin that targets a specific piece of hardware or requires a complex or hard-to-find testing environment, we recommend that you send us as much detail as possible.

Specific Hardware Examples:

  • GPU related
    • Specific support required cuda / mps ( Please not cuda via ROCm if related )
    • Minium GPU Memory

Complex Software Examples:

  • Expensive proprietary software
  • Software with an extensive installation process
  • Software without an English language UI

@github-actions
Copy link
Contributor

github-actions bot commented Oct 21, 2025

DCO Assistant Lite bot All contributors have signed the DCO ✍️ ✅

@2020ashish 2020ashish changed the title Grandma win 11 product name & goal update Win11 probe still uses Windows 10 product names and goal Oct 21, 2025
@2020ashish 2020ashish changed the title Win11 probe still uses Windows 10 product names and goal FIX: Win11 probe still uses Windows 10 product names and goal Oct 21, 2025
@2020ashish
Copy link
Contributor Author

2020ashish commented Oct 21, 2025

Hi @leondz / @jmartin-tech can you review this issue no. #1423

@2020ashish
Copy link
Contributor Author

I have read the DCO Document and I hereby sign the DCO

@2020ashish
Copy link
Contributor Author

recheck

github-actions bot added a commit that referenced this pull request Oct 21, 2025
Copy link
Collaborator

@jmartin-tech jmartin-tech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was an interesting find, however I think the approach needs to be adjusted.

For Win10 the product name list it extracted from the keyedprod_win10 payload file. This is the desired format, however the existing Win11 incorrectly expects to just override the PRODUCT_NAME constant.

A more consistent (untested) fix is noted though a new payload file needs to be created.

Co-authored-by: Jeffrey Martin <jmartin@Op3n4M3.dev>
Signed-off-by: Ashish RajAnand <81062149+2020ashish@users.noreply.github.com>
2020ashish

This comment was marked as duplicate.

@2020ashish
Copy link
Contributor Author

Hi @jmartin-tech, updates pushed — ready for re-review.
Thanks for the earlier feedback!

@leondz
Copy link
Collaborator

leondz commented Oct 22, 2025

Great catch, thank you

@2020ashish
Copy link
Contributor Author

Hi @leondz updates pushed

Copy link
Collaborator

@leondz leondz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@jmartin-tech jmartin-tech merged commit 3746886 into NVIDIA:main Oct 23, 2025
15 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Oct 23, 2025
@jmartin-tech jmartin-tech changed the title FIX: Win11 probe still uses Windows 10 product names and goal fix: Win11 probe still uses Windows 10 product names and goal Oct 23, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants