fix: Win11 probe still uses Windows 10 product names and goal#1422
Merged
jmartin-tech merged 5 commits intoNVIDIA:mainfrom Oct 23, 2025
Merged
fix: Win11 probe still uses Windows 10 product names and goal#1422jmartin-tech merged 5 commits intoNVIDIA:mainfrom
jmartin-tech merged 5 commits intoNVIDIA:mainfrom
Conversation
Contributor
|
DCO Assistant Lite bot All contributors have signed the DCO ✍️ ✅ |
Contributor
Author
|
Hi @leondz / @jmartin-tech can you review this issue no. #1423 |
Contributor
Author
|
Contributor
Author
|
recheck |
jmartin-tech
requested changes
Oct 21, 2025
Collaborator
There was a problem hiding this comment.
This was an interesting find, however I think the approach needs to be adjusted.
For Win10 the product name list it extracted from the keyedprod_win10 payload file. This is the desired format, however the existing Win11 incorrectly expects to just override the PRODUCT_NAME constant.
A more consistent (untested) fix is noted though a new payload file needs to be created.
Co-authored-by: Jeffrey Martin <jmartin@Op3n4M3.dev> Signed-off-by: Ashish RajAnand <81062149+2020ashish@users.noreply.github.com>
Contributor
Author
|
Hi @jmartin-tech, updates pushed — ready for re-review. |
leondz
reviewed
Oct 22, 2025
Collaborator
|
Great catch, thank you |
Contributor
Author
|
Hi @leondz updates pushed |
jmartin-tech
approved these changes
Oct 23, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue No. #1423
✅ Summary
Fixes
Win11prompts so they use Windows 11 product names instead of inheriting Windows 10.Now
Win11correctly generates prompts with"Windows 11","Windows 11 Pro", and"Windows 11 Home".Goal Updated
Prompt Details Updated
{product_name}placeholders now use the correct product names for each probe.Fixes Issue
N/A (add GitHub issue # if applicable)
🔄 Changes Introduced
Win11to use its own payload and prompts instead of inheriting Windows 10 data.Win10to load payloads dynamically viaself.payload.payload = "keyedprod_win11"so its prompts are generated from the new payload file.Verification
List the steps needed to make sure this thing works
python -m pytest tests/If you are opening a PR for a new plugin that targets a specific piece of hardware or requires a complex or hard-to-find testing environment, we recommend that you send us as much detail as possible.
Specific Hardware Examples:
cuda/mps( Please notcudaviaROCmif related )Complex Software Examples: