correct _mint_attempt conversation support#1417
Merged
jmartin-tech merged 3 commits intoNVIDIA:mainfrom Oct 21, 2025
Merged
Conversation
Signed-off-by: Jeffrey Martin <jemartin@nvidia.com>
Signed-off-by: Jeffrey Martin <jemartin@nvidia.com>
aishwaryap
reviewed
Oct 17, 2025
Signed-off-by: Jeffrey Martin <jemartin@nvidia.com>
jmartin-tech
force-pushed
the
fix/mint_attempt_conversation
branch
from
3cedf05 to
4f346c8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#1337 added system prompt support that is expected to handle
Conversationobjects, however subsequent testing of this unused code path surfaces incorrect handling of the existing list ofTurnobjects.In the scenario where a
Conversationwas passed that does not already contain asystem_promptmessage the existing turns shouldextendthe intermediate list with thesystemprompt message prepended.In the scenario where a
Conversationwas passed and no system_prompt exists at all, the intent is for the localturnslist to still be empty and the original object passed as prompt will simply pass thru to the attempt creation.Verification
List the steps needed to make sure this thing works