Fix/recommended detector migration#1409
Merged
jmartin-tech merged 8 commits intoNVIDIA:mainfrom Oct 23, 2025
Merged
Conversation
…tended pattern Signed-off-by: Patricia Pampanelli <[email protected]>
Signed-off-by: Patricia Pampanelli <[email protected]>
Signed-off-by: Patricia Pampanelli <[email protected]>
Signed-off-by: Patricia Pampanelli <[email protected]>
Signed-off-by: Patricia Pampanelli <[email protected]>
Signed-off-by: Patricia Pampanelli <[email protected]>
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
leondz
approved these changes
Oct 22, 2025
| ): | ||
| from garak import command | ||
| command.deprecation_notice( | ||
| f"recommended_detector in probe {self.probename}", |
Collaborator
There was a problem hiding this comment.
Suggested change
| f"recommended_detector in probe {self.probename}", | |
| f"recommended_detector in probe {self.probename} - use primary_detector and extended_detectors", |
| "prompts", | ||
| "triggers", | ||
| "post_buff_hook", | ||
| "recommended_detector", |
| * `resources/` - ancillary items required by plugins | ||
|
|
||
| The default operating mode is to use the `probewise` harness. Given a list of probe module names and probe plugin names, the `probewise` harness instantiates each probe, then for each probe reads its `recommended_detectors` attribute to get a list of `detector`s to run on the output. | ||
| The default operating mode is to use the `probewise` harness. Given a list of probe module names and probe plugin names, the `probewise` harness instantiates each probe, then for each probe reads its `primary_detector` and `extended_detectors` attributes to get a list of `detector`s to run on the output. |
Collaborator
There was a problem hiding this comment.
wow this was important to update, thanks
Signed-off-by: Leon Derczynski <[email protected]>
jmartin-tech
approved these changes
Oct 23, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses issue #531 by migrating from the deprecated recommended_detector attribute to the new primary/extended pattern. The migration maintains backward compatibility through fallback mechanism.
Changes
recommended_detectorattributetests/probes/test_probes.py)docs/source/how.rstdocs/source/extending.probe.rstREADME.mdgarak/_plugins.py)"recommended_detector"to theskip_fieldslist in theplugin_infomethodplugin_cache.json