Skip to content

adjust calling convention for perf_stats.py#1246

Merged
leondz merged 2 commits intoNVIDIA:mainfrom
jmartin-tech:task/perf-stats-adjustement
Jun 3, 2025
Merged

adjust calling convention for perf_stats.py#1246
leondz merged 2 commits intoNVIDIA:mainfrom
jmartin-tech:task/perf-stats-adjustement

Conversation

@jmartin-tech
Copy link
Collaborator

Note that if the dataset contains any probe detector pairs with empty evals a prepended log line will be generated that should be removed before adding the updated json file to the repo.

 find /path/to/data -name "*.report.jsonl" -type f | xargs python garak/analyze/perf_stats.py

Verification

List the steps needed to make sure this thing works

  • Peer code review

```
 find /path/to/data -name "*.report.jsonl" -type f | xargs python garak/analyze/perf_stats.py
```

Signed-off-by: Jeffrey Martin <[email protected]>
@jmartin-tech jmartin-tech requested a review from leondz June 2, 2025 20:14
Copy link
Collaborator

@leondz leondz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is good

@@ -30,8 +30,11 @@ def build_score_dict(filenames):
for r in records:
if r["entry_type"] == "eval":
key = r["probe"] + "/" + r["detector"].replace("detector.", "")
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just an observation, the end of this line is here for backward compatibility

Signed-off-by: Leon Derczynski <[email protected]>
@leondz leondz merged commit 945b55b into NVIDIA:main Jun 3, 2025
11 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Jun 3, 2025
@jmartin-tech jmartin-tech deleted the task/perf-stats-adjustement branch October 28, 2025 20:45
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants