Skip to content

probes: package hallucination support for dart, perl, & raku#1243

Merged
jmartin-tech merged 28 commits intoNVIDIA:mainfrom
dchiitmalla:consolidate-dart-perl-raku
Sep 26, 2025
Merged

probes: package hallucination support for dart, perl, & raku#1243
jmartin-tech merged 28 commits intoNVIDIA:mainfrom
dchiitmalla:consolidate-dart-perl-raku

Conversation

@dchiitmalla
Copy link
Contributor

Consolidates PRs: #1242, #1241, #1235

@dchiitmalla dchiitmalla mentioned this pull request May 30, 2025
@leondz leondz added the probes Content & activity of LLM probes label Jun 2, 2025
This was referenced Jun 6, 2025
@leondz leondz self-requested a review July 2, 2025 07:01
Copy link
Collaborator

@leondz leondz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no major revisions, import format change to avoid dupes & please set licenses on HF datasets

@dchiitmalla dchiitmalla requested a review from leondz July 4, 2025 16:20
Copy link
Collaborator

@jmartin-tech jmartin-tech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor adjustment requests.

@leondz leondz marked this pull request as draft August 7, 2025 09:50
Abhiraj-GetGarak and others added 9 commits August 9, 2025 21:26
- Remove unnecessary method overrides in Perl and Raku detectors
- Keep Dart detector override for case-insensitive matching
- Revert dataset scripts to JSONL format for HuggingFace compatibility
- Add tools requirements.txt with additional dependencies

Signed-off-by: Claude <[email protected]>

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <[email protected]>
@dchiitmalla dchiitmalla marked this pull request as ready for review August 10, 2025 21:18
dchiitmalla and others added 3 commits August 10, 2025 14:19
* update to use garak-llm org datasources
* use `Message` object in tests

Signed-off-by: Jeffrey Martin <[email protected]>
Copy link
Collaborator

@jmartin-tech jmartin-tech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Testing shows the package extractions for Perl and Raku need improvement.

I have added a suggestion that adds expectations that code is predicated by a newline or markdown code-block syntax. This may be a reasonable improvement, though I am guessing there are more edge cases that could be seen, so happy to test other ideas for revision.

Test cases should likely be added to account for the regex changes.

Copy link
Collaborator

@erickgalinkin erickgalinkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not confident in the regular expressions -- would like to understand why we aren't using ^ and/or $ in the matches. Not sure I grab the suggestions on multiline.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Meta comment: We should make this test file a lot DRYer.

@jmartin-tech jmartin-tech changed the title Consolidate dart perl raku probes: package hallucination support for dart, perl, & raku Sep 26, 2025
@jmartin-tech jmartin-tech merged commit 9414509 into NVIDIA:main Sep 26, 2025
17 of 18 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Sep 26, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

probes Content & activity of LLM probes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants