Skip to content

reporting: change default aggregation#1234

Merged
jmartin-tech merged 1 commit intoNVIDIA:mainfrom
leondz:reporting/default_agg
May 28, 2025
Merged

reporting: change default aggregation#1234
jmartin-tech merged 1 commit intoNVIDIA:mainfrom
leondz:reporting/default_agg

Conversation

@leondz
Copy link
Collaborator

@leondz leondz commented May 27, 2025

Reporting tweaks:

  • change default module-level aggregation to lower quartile
  • note aggregation method in tooltip
  • fix group template name to match passed variable
  • remove extraneous text in group template
  • capitalise report heading

@leondz leondz added this to the release 0.11.0 milestone May 27, 2025
@leondz leondz added the reporting Reporting, analysis, and other per-run result functions label May 27, 2025
Copy link
Collaborator

@erickgalinkin erickgalinkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've not tested it but assume you did. I like the move here.

@leondz
Copy link
Collaborator Author

leondz commented May 27, 2025

I've not tested it but assume you did. I like the move here.

tested with

  • show_top_group_score = true/false, checking for present/absent group-level figure
  • group_aggregation_function lower_quartile/mean_minus_sd/proportion_passing having just one probe (-p tap), looking for crashes and correct report content
  • calling statistics.*() (for relevant members of *) to check behaviour with lists of length 1

@jmartin-tech jmartin-tech merged commit 7901145 into NVIDIA:main May 28, 2025
12 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators May 28, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

reporting Reporting, analysis, and other per-run result functions

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants