replicate generator pickle support improvements#1190
Merged
jmartin-tech merged 1 commit intoNVIDIA:mainfrom May 2, 2025
Merged
replicate generator pickle support improvements#1190jmartin-tech merged 1 commit intoNVIDIA:mainfrom
jmartin-tech merged 1 commit intoNVIDIA:mainfrom
Conversation
Signed-off-by: Jeffrey Martin <jemartin@nvidia.com>
jmartin-tech
force-pushed
the
fix/replicate-multiprocessing
branch
from
1fe7d39 to
719a089
Compare
erickgalinkin
approved these changes
May 2, 2025
Collaborator
erickgalinkin
left a comment
erickgalinkin
left a comment
There was a problem hiding this comment.
LGTM. Shout out for the added test!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix #1160
Following patterns established in
openaiadd_loadand_clearmethods for client objects. A number of other generators have be identified for potential enhancement for objects that cannot pickle in generators. These additional generators will be addressed separately.Verification
List the steps needed to make sure this thing works