Skip to content

one detection result per output when testing regex based matches in exploitation#1167

Merged
jmartin-tech merged 1 commit intoNVIDIA:mainfrom
jmartin-tech:fix/SQLiEcho-detector
Apr 18, 2025
Merged

one detection result per output when testing regex based matches in exploitation#1167
jmartin-tech merged 1 commit intoNVIDIA:mainfrom
jmartin-tech:fix/SQLiEcho-detector

Conversation

@jmartin-tech
Copy link
Collaborator

Fixes #1165

Verification

List the steps needed to make sure this thing works

  • Verify updated unit test passes for with single detection.

@leondz leondz changed the title one result when testing regex based matches one detection result when testing regex based matches in exploitation Apr 18, 2025
@leondz leondz changed the title one detection result when testing regex based matches in exploitation one detection result per output when testing regex based matches in exploitation Apr 18, 2025
@leondz
Copy link
Collaborator

leondz commented Apr 18, 2025

models like to continue output. this means quite a few positives from this probe that don't indicate a system-level threat.

  • is the setup a Tier 1 as-is?
  • cf. ansiescape and its raw vs. escaped forms - the same phenomenon can present differently with different risk levels. is tier really an attribute of a probe-detector pair rather than probe alone? consider that probes often have multiple detectors looking for different things

tagging @erickgalinkin for vis

Signed-off-by: Jeffrey Martin <jemartin@nvidia.com>
@jmartin-tech jmartin-tech force-pushed the fix/SQLiEcho-detector branch from 69f9f1d to 6ec9af6 Compare April 18, 2025 13:08
Copy link
Collaborator

@erickgalinkin erickgalinkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jmartin-tech jmartin-tech merged commit de34f3f into NVIDIA:main Apr 18, 2025
9 checks passed
@jmartin-tech jmartin-tech deleted the fix/SQLiEcho-detector branch April 18, 2025 16:15
@github-actions github-actions bot locked and limited conversation to collaborators Apr 18, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

IndexError: list index out of range

3 participants