Add audio NIM model and audio probes#1163
Merged
jmartin-tech merged 31 commits intoNVIDIA:mainfrom Jun 11, 2025
Merged
Conversation
erickgalinkin
force-pushed
the
audio-probes
branch
2 times, most recently
from
633969e to
3a5282a
Compare
jmartin-tech
reviewed
May 5, 2025
jmartin-tech
reviewed
May 5, 2025
…ents for `audio` group.
Co-authored-by: Jeffrey Martin <[email protected]> Signed-off-by: Erick Galinkin <[email protected]>
jmartin-tech
force-pushed
the
audio-probes
branch
from
e7ea04c to
4791856
Compare
Signed-off-by: Jeffrey Martin <[email protected]>
Collaborator
|
It would be good to hold off on landing this til after #1199 turns up (post v0.11.0), to avoid increasing base dep size? Definitely happy to do a point release for audio |
jmartin-tech
force-pushed
the
audio-probes
branch
from
34a6ba8 to
bfb029f
Compare
jmartin-tech
requested changes
May 15, 2025
Collaborator
jmartin-tech
left a comment
jmartin-tech
left a comment
There was a problem hiding this comment.
Looks pretty reasonable, a few consistency requests and configurability patterns to adjust.
Co-authored-by: Jeffrey Martin <[email protected]> Signed-off-by: Erick Galinkin <[email protected]>
Co-authored-by: Jeffrey Martin <[email protected]> Signed-off-by: Erick Galinkin <[email protected]>
Co-authored-by: Jeffrey Martin <[email protected]> Signed-off-by: Erick Galinkin <[email protected]>
Co-authored-by: Jeffrey Martin <[email protected]> Signed-off-by: Erick Galinkin <[email protected]>
Co-authored-by: Jeffrey Martin <[email protected]> Signed-off-by: Erick Galinkin <[email protected]>
Co-authored-by: Jeffrey Martin <[email protected]> Signed-off-by: Erick Galinkin <[email protected]>
Co-authored-by: Jeffrey Martin <[email protected]> Signed-off-by: Erick Galinkin <[email protected]>
Co-authored-by: Jeffrey Martin <[email protected]> Signed-off-by: Erick Galinkin <[email protected]>
Collaborator
Author
I support landing this after #1199, but would this increase base dep size? I believe the additional dependencies are slated off under the |
Signed-off-by: Jeffrey Martin <[email protected]>
…_prompt"` parameter in `DEFAULT_PARAMS` for configurability.
jmartin-tech
requested changes
May 28, 2025
Collaborator
jmartin-tech
left a comment
jmartin-tech
left a comment
There was a problem hiding this comment.
Minor tweak to connect the dots for backoff.
jmartin-tech
requested changes
Jun 9, 2025
…s modality check in visual_jailbreak.py. Fix return type. Remove unused inputs.
Collaborator
jmartin-tech
left a comment
jmartin-tech
left a comment
There was a problem hiding this comment.
Testing based on d07bfdf looks good for the target goals of this PR.
jmartin-tech
approved these changes
Jun 11, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds support for audio probes using [the datasets I have somewhere] and multimodal NIM.