Removed detector prefix from eval records#1157
Merged
jmartin-tech merged 4 commits intoNVIDIA:mainfrom Apr 18, 2025
Merged
Conversation
Contributor
|
DCO Assistant Lite bot All contributors have signed the DCO ✍️ ✅ |
Contributor
Author
|
I have read the DCO Document and I hereby sign the DCO |
Contributor
Author
|
recheck |
jmartin-tech
approved these changes
Apr 15, 2025
Collaborator
jmartin-tech
left a comment
There was a problem hiding this comment.
I welcome the consistency improvement here, just one required change I can address while landing to remove the excess fixture exectutions.
Noting example for change this PR makes.
Old:
{
"entry_type": "eval",
"probe": "av_spam_scanning.GTphish",
"detector": "detector.knownbadsignatures.GTphish",
"passed": 15,
"total": 25
}
New:
{
"entry_type": "eval",
"probe": "av_spam_scanning.GTphish",
"detector": "knownbadsignatures.GTphish",
"passed": 15,
"total": 25
}
jmartin-tech
previously requested changes
Apr 15, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes #1128.
Changed
base.Evaluatorto not add thedetector.prefix to thedetectorvalue in the evaluation records written to the_config.transient.reportfilejsonl.Added
*.report.jsonlfile does not contain thedetector.prefix.mitigation_outputsfixture toconftestsmodule as this is shared by two unit test modules.Fixed
probes.latentinjectionmodule to have defaultgenerationsparam: unit tests were failing for me without this.Verification
python -m pytest tests/detector.prefix. E.g. the CMD:should have the following entries in the produced
/Users/*/.local/share/garak/garak_runs/garak.*report.jsonl: