update: add soft prompt caps to encoding probes#1154
Conversation
… prompts & triggers
jmartin-tech
left a comment
There was a problem hiding this comment.
The targeted change looks reasonable.
This PR highlights a configurable pattern divergence for this module that should be refactored soon.
The module level _load_payloads() method here should not need to access _config in a hardcoded path. This also causes churn the method level globals for payloads & extra_tags.
|
Agree, good catch |
|
Prior to this change triggers were already populated when Merge of #943 suggests some adjustments here to ensure language ( I suspect adjusting the distribution of payloads as class level param following the patterns in Taking this as an action item to resolve during testing to ensure original PR intent is completed. |
Signed-off-by: Jeffrey Martin <jemartin@nvidia.com>
Signed-off-by: Jeffrey Martin <jemartin@nvidia.com>
jmartin-tech
left a comment
There was a problem hiding this comment.
Consistency question noted, thoughts?
|
Yup, sure. Comment diffs out of date else would've put them through. |
Signed-off-by: Jeffrey Martin <jemartin@nvidia.com>
|
Noting the language provision here attempts to translate payloads that are (a) looked for as exact matches (b) may explicitly have non-language assigned. Not to be addressed in the PR. |
encodingprobes now support soft prompt caps by default. These include prompt set expansion due to custom payloads.Verification
List the steps needed to make sure this thing works
-g 1, check that prompt count is under 256 / soft_probe_prompt_capfollow_prompt_cap: false, note that prompt count can go over 256 cap (may require extra payloads)