generators: add option to skip output btw given delimiters; add hook for postprocessing#1097
Merged
jmartin-tech merged 14 commits intoNVIDIA:mainfrom Feb 20, 2025
Merged
Conversation
jmartin-tech
reviewed
Feb 7, 2025
Collaborator
jmartin-tech
left a comment
There was a problem hiding this comment.
Testing shows this works however the long length of responses often truncates before the </think> output, often leaving the full response that started with <think>... in the result.
Also noted that I do not believe timeout should be suppressed by default for OpenAICompatible.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
generators.base.Generator._prune_skip_sequences()to cut content btwGenerator.skip_seq_startandGenerator.skip_seq_endgenerators.base.Generator._post_generate_hook()to allow postprocessing of output in generatorsopenaiexceptions caused by interrupted thought (e.g. when hitting max_tokens)OpenAICompatibleVerification
python -m pytest tests/generators/test_generators_base.pypython -m pytest tests/generators/test_generators.pytest.Repeat, it should work as normal (output==prompt)skip_seq_startandskip_seq_end, content int he middle should be pruneddocs/source/garak.generators.base.rst