Update for latest ollama support#1092
Merged
jmartin-tech merged 3 commits intoNVIDIA:mainfrom Jan 30, 2025
Merged
Conversation
The latest ollama package changed the error raised from httpx to OSError * set new minimum version for ollama > 0.4.7 * update error handler in test
erickgalinkin
approved these changes
Jan 29, 2025
Collaborator
erickgalinkin
left a comment
erickgalinkin
left a comment
There was a problem hiding this comment.
Looks good to me!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The latest
ollamapackage changed the error raised fromhttpxtoOSError.To provide early detection of similar issues a workflow triggering pytest and package testing is also added.
Adding
workflow_callto existing workflows allows the new workflow to reuse them.For now the action results will need to be reviewed periodically, notifications for failures can be added in the future.