Additional XSS Exfil Probes#1060
Merged
jmartin-tech merged 11 commits intoNVIDIA:mainfrom Feb 10, 2025
Merged
Conversation
… more carefully in detector
…be since it belongs in a different probe class.
erickgalinkin
force-pushed
the
996-probe-more-xss-exfil-probes
branch
from
6bf5642 to
436e8db
Compare
Collaborator
jmartin-tech
left a comment
jmartin-tech
left a comment
There was a problem hiding this comment.
All seems in order, added some thoughts about a possible guard check and structure of prompt creation in the new probe classes.
Co-authored-by: Jeffrey Martin <jmartin@Op3n4M3.dev> Signed-off-by: Erick Galinkin <erick.galinkin@gmail.com>
jmartin-tech
approved these changes
Feb 10, 2025
Collaborator
jmartin-tech
left a comment
jmartin-tech
left a comment
There was a problem hiding this comment.
This looks reasonable, if it make sense to remove the leading whitespace or newlines noted that can be completed as part of the merge.
Co-authored-by: Jeffrey Martin <jmartin@Op3n4M3.dev> Signed-off-by: Erick Galinkin <erick.galinkin@gmail.com>
jmartin-tech
added a commit
that referenced
this pull request
Feb 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #996