Fix matrix.h: set_slice3x3 -> set_slice_3x3#1784
Merged
hwu36 merged 1 commit intoNVIDIA:mainfrom Sep 6, 2024
Merged
Conversation
hwu36
approved these changes
Sep 6, 2024
hgl71964
pushed a commit
to hgl71964/cutlass
that referenced
this pull request
Feb 21, 2025
JackWolfard
added a commit
to JackWolfard/xla
that referenced
this pull request
Feb 26, 2025
Clang 19 is more strict than Clang 18 about missing members for template instantiations. CUTLASS has already already fixed this in NVIDIA/cutlass#1784, but the XLA fork of CUTLASS is out of date and needs to be patched in order to build GPU kernels with Clang > 19. To test this change, run the following locally: ```sh $ docker run --rm -it \ --name xla \ -v $PWD:/xla \ -w /tmp \ silkeh/clang:19 $ wget https://github.com/bazelbuild/bazelisk/releases/download/v1.25.0/bazelisk-amd64.deb $ dpkg -i bazelisk-amd64.deb $ cd /xla $ ./configure.py \ --backend=CUDA \ --cuda_compiler=CLANG \ --cuda_compute_capabilities=9.0 $ bazel \ build \ --repo_env=HERMETIC_PYTHON_VERSION=3.11 \ --repo_env=HERMETIC_CUDA_VERSION="12.8.0" \ --repo_env=HERMETIC_CUDNN_VERSION="9.7.1" \ --test_output=all \ --spawn_strategy=sandboxed \ //xla/service/gpu/kernels:cutlass_gemm_kernel_f32xf32_to_f32 ```
JackWolfard
added a commit
to JackWolfard/xla
that referenced
this pull request
Feb 26, 2025
Clang 19 is stricter than Clang 18 about missing members for template instantiations. CUTLASS has already fixed this in NVIDIA/cutlass#1784, but the XLA fork of CUTLASS is out of date and needs to be patched in order to build GPU kernels with Clang > 19. To test this change, run the following locally: ```sh $ docker run --rm -it \ --name xla \ -v $PWD:/xla \ -w /tmp \ silkeh/clang:19 $ wget https://github.com/bazelbuild/bazelisk/releases/download/v1.25.0/bazelisk-amd64.deb $ dpkg -i bazelisk-amd64.deb $ cd /xla $ ./configure.py \ --backend=CUDA \ --cuda_compiler=CLANG \ --cuda_compute_capabilities=9.0 $ bazel \ build \ --repo_env=HERMETIC_PYTHON_VERSION=3.11 \ --repo_env=HERMETIC_CUDA_VERSION="12.8.0" \ --repo_env=HERMETIC_CUDNN_VERSION="9.7.1" \ --test_output=all \ --spawn_strategy=sandboxed \ //xla/service/gpu/kernels:cutlass_gemm_kernel_f32xf32_to_f32 ```
andralex
pushed a commit
to andralex/cutlass
that referenced
this pull request
Jun 14, 2025
Albresky
pushed a commit
to Albresky/cutlass
that referenced
this pull request
Oct 11, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #1783