Skip to content

ci(pr): exclude skills/**/evals/** from test-trigger filters#1170

Merged
rgsl888prabhu merged 1 commit into
NVIDIA:mainfrom
rgsl888prabhu:ci-skip-evals-from-test-triggers
May 1, 2026
Merged

ci(pr): exclude skills/**/evals/** from test-trigger filters#1170
rgsl888prabhu merged 1 commit into
NVIDIA:mainfrom
rgsl888prabhu:ci-skip-evals-from-test-triggers

Conversation

@rgsl888prabhu
Copy link
Copy Markdown
Collaborator

Summary

The changed-files filter groups in .github/workflows/pr.yaml (test_cpp, test_python_conda, test_python_wheels) already exclude skills/**/SKILL.md and skills/**/resources/** so doc-only changes to those paths skip the build/test pipeline. The same exclusion was missing for skills/**/evals/**, so adding or editing an evals.json unnecessarily triggers conda-cpp-build, conda-python-build, the wheel builds, and downstream tests.

This PR adds '!skills/**/evals/**' to the three test-trigger filter groups, matching the treatment of other non-buildable skill content.

Notes

  • build_docs is intentionally not changed — it does not exclude SKILL.md or resources/** either, so docs-build behavior is unchanged for all skill content.
  • Verified by:
    • python3 -c "import yaml; yaml.safe_load(open('.github/workflows/pr.yaml'))" — YAML parses
    • pre-commit run --files .github/workflows/pr.yaml — all hooks pass

The pr.yaml changed-files filter groups (test_cpp, test_python_conda,
test_python_wheels) already exclude skills/**/SKILL.md and
skills/**/resources/** so doc-only edits to those paths skip the
expensive build/test pipeline. The same exclusion was missing for
skills/**/evals/**, so adding or editing an evaluation dataset
unnecessarily triggers conda-cpp-build, conda-python-build, wheel
builds, and downstream test jobs even though no buildable code or test
fixture has changed.

Treat eval datasets the same as the other non-buildable skill content:
add '!skills/**/evals/**' to the three test groups. The build_docs
group is intentionally left unchanged — it does not exclude SKILL.md
or resources/** either, so the docs build's behavior is unchanged for
all skill content.

Signed-off-by: Ramakrishna Prabhu <[email protected]>
@copy-pr-bot
Copy link
Copy Markdown

copy-pr-bot Bot commented May 1, 2026

Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually.

Contributors can view more details about this message here.

@rgsl888prabhu rgsl888prabhu added non-breaking Introduces a non-breaking change improvement Improves an existing functionality labels May 1, 2026
@rgsl888prabhu rgsl888prabhu self-assigned this May 1, 2026
@rgsl888prabhu rgsl888prabhu marked this pull request as ready for review May 1, 2026 15:47
@rgsl888prabhu rgsl888prabhu requested a review from a team as a code owner May 1, 2026 15:47
@rgsl888prabhu rgsl888prabhu requested a review from bdice May 1, 2026 15:47
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 1, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 3cc63529-15ff-4886-840a-defc7ea1bfbd

📥 Commits

Reviewing files that changed from the base of the PR and between 746f46b and f3816ea.

📒 Files selected for processing (1)
  • .github/workflows/pr.yaml

📝 Walkthrough

Walkthrough

The workflow configuration in .github/workflows/pr.yaml is modified to add an exclusion pattern !skills/**/evals/** to the change-group globs for build_docs, test_cpp, test_python_conda, and test_python_wheels, preventing these CI jobs from being triggered by changes solely within the evals subdirectories.

Changes

Cohort / File(s) Summary
CI Configuration
.github/workflows/pr.yaml
Added exclusion pattern !skills/**/evals/** to four change-group globs (build_docs, test_cpp, test_python_conda, test_python_wheels) to skip CI jobs when only evaluation-related files are modified.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title directly and specifically describes the main change: adding exclusion patterns for skills//evals/ to CI test-trigger filters in the workflow file.
Description check ✅ Passed The description clearly relates to the changeset by explaining the rationale for excluding skills//evals/ from test triggers and noting which groups are affected.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Review rate limit: 9/10 reviews remaining, refill in 6 minutes.

Comment @coderabbitai help to get the list of available commands and usage tips.

@rgsl888prabhu rgsl888prabhu merged commit 4aeb8c2 into NVIDIA:main May 1, 2026
194 of 213 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

improvement Improves an existing functionality non-breaking Introduces a non-breaking change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants