ci(pr): exclude skills/**/evals/** from test-trigger filters#1170
Conversation
The pr.yaml changed-files filter groups (test_cpp, test_python_conda, test_python_wheels) already exclude skills/**/SKILL.md and skills/**/resources/** so doc-only edits to those paths skip the expensive build/test pipeline. The same exclusion was missing for skills/**/evals/**, so adding or editing an evaluation dataset unnecessarily triggers conda-cpp-build, conda-python-build, wheel builds, and downstream test jobs even though no buildable code or test fixture has changed. Treat eval datasets the same as the other non-buildable skill content: add '!skills/**/evals/**' to the three test groups. The build_docs group is intentionally left unchanged — it does not exclude SKILL.md or resources/** either, so the docs build's behavior is unchanged for all skill content. Signed-off-by: Ramakrishna Prabhu <[email protected]>
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe workflow configuration in Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Review rate limit: 9/10 reviews remaining, refill in 6 minutes. Comment |
Summary
The
changed-filesfilter groups in.github/workflows/pr.yaml(test_cpp,test_python_conda,test_python_wheels) already excludeskills/**/SKILL.mdandskills/**/resources/**so doc-only changes to those paths skip the build/test pipeline. The same exclusion was missing forskills/**/evals/**, so adding or editing anevals.jsonunnecessarily triggersconda-cpp-build,conda-python-build, the wheel builds, and downstream tests.This PR adds
'!skills/**/evals/**'to the three test-trigger filter groups, matching the treatment of other non-buildable skill content.Notes
build_docsis intentionally not changed — it does not excludeSKILL.mdorresources/**either, so docs-build behavior is unchanged for all skill content.python3 -c "import yaml; yaml.safe_load(open('.github/workflows/pr.yaml'))"— YAML parsespre-commit run --files .github/workflows/pr.yaml— all hooks pass