Skip to content

Conversation

@keenan-simpson
Copy link
Contributor

@keenan-simpson keenan-simpson commented Jan 23, 2025

Add a note about using the getters and setters directly to avoid implementation details which break common pythonic code patterns

close #262

@copy-pr-bot
Copy link
Contributor

copy-pr-bot bot commented Jan 23, 2025

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@keenan-simpson keenan-simpson self-assigned this Jan 23, 2025
@keenan-simpson keenan-simpson added documentation Improvements or additions to documentation enhancement Any code-related improvements cuda.bindings Everything related to the cuda.bindings module P0 High priority - Must do! labels Jan 23, 2025
@keenan-simpson
Copy link
Contributor Author

/ok to test

@github-actions

This comment has been minimized.

@keenan-simpson keenan-simpson marked this pull request as ready for review January 23, 2025 22:15
@leofang leofang requested review from rwgk and removed request for leofang January 24, 2025 02:10
@keenan-simpson
Copy link
Contributor Author

/ok to test

rwgk
rwgk previously approved these changes Jan 24, 2025
@leofang
Copy link
Member

leofang commented Jan 24, 2025

Admin-merge during release meeting, proceed to #366.

@leofang leofang merged commit cf9d560 into NVIDIA:main Jan 24, 2025
1 check passed
@github-actions
Copy link

Doc Preview CI
Preview removed because the pull request was closed or merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cuda.bindings Everything related to the cuda.bindings module documentation Improvements or additions to documentation enhancement Any code-related improvements P0 High priority - Must do!

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Document that struct binding getters return a copy of a value and propagating any changes must go through the setter

3 participants