Skip to content

[Backport] Enable Cython tests for cuda.bindings #359

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
leofang merged 12 commits into from
Jan 10, 2025
Merged

[Backport] Enable Cython tests for cuda.bindings #359

leofang merged 12 commits into from
Jan 10, 2025

Conversation

@leofang
Copy link
Member

@leofang leofang commented Jan 6, 2025

Cherry-picked from #323.

@leofang
Enable Cython tests for cuda.bindings (NVIDIA#323)
a13d6be 
* enable Cython tests for cuda.bindings

* build Cython test modules

* Update gh-build-and-test.yml

* Install system gcc

* No sudo

* also set CUDA_HOME

* Try to find Python include

* nit: add a skip condition and comments

* simplify
@leofang leofang added P1 Medium priority - Should do CI/CD CI/CD infrastructure labels Jan 6, 2025
@leofang leofang added this to the cuda-python 12-next, 11-next milestone Jan 6, 2025
@leofang leofang requested a review from vzhurba01 January 6, 2025 21:34
@leofang leofang self-assigned this Jan 6, 2025
@copy-pr-bot
Copy link
Contributor

copy-pr-bot bot commented Jan 6, 2025

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@leofang leofang added the cuda.bindings Everything related to the cuda.bindings module label Jan 6, 2025
@leofang
Copy link
Member Author

leofang commented Jan 6, 2025

/ok to test

@leofang
Copy link
Member Author

leofang commented Jan 6, 2025

Auto-backport of the new script has failed (#252 (comment)), let me hack it quickly in this PR.

@leofang
Copy link
Member Author

leofang commented Jan 6, 2025

/ok to test

@leofang
Copy link
Member Author

leofang commented Jan 6, 2025

/ok to test

@leofang
Copy link
Member Author

leofang commented Jan 8, 2025

/ok to test

@leofang
Copy link
Member Author

leofang commented Jan 8, 2025

I am clueless...

+ CPLUS_INCLUDE_PATH=/__w/cuda-python/cuda-python/cuda_toolkit/include:
+ cythonize -3 -i test_ccuda.pyx test_ccudart.pyx test_interoperability_cython.pyx
Compiling /__w/cuda-python/cuda-python/cuda_bindings/tests_cython/test_ccuda.pyx because it changed.
/__w/cuda-python/cuda-python/cuda_bindings/tests_cython/test_ccuda.c:1242:10: fatal error: cuda.h: No such file or directory
 1242 | #include "cuda.h"
      |          ^~~~~~~~

@leofang
Copy link
Member Author

leofang commented Jan 9, 2025

/ok to test

@leofang
Copy link
Member Author

leofang commented Jan 9, 2025

/ok to test

@leofang
Copy link
Member Author

leofang commented Jan 10, 2025

/ok to test

@leofang
Copy link
Member Author

leofang commented Jan 10, 2025

/ok to test

@leofang
Copy link
Member Author

leofang commented Jan 10, 2025

/ok to test

leofang
leofang commented Jan 10, 2025
View reviewed changes
@leofang
Copy link
Member Author

leofang commented Jan 10, 2025

This is ready.

@leofang leofang merged commit e56b97a into NVIDIA:11.8.x Jan 10, 2025
26 checks passed
@leofang leofang deleted the cython_11_8 branch January 10, 2025 19:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@vzhurba01 vzhurba01 vzhurba01 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@leofang leofang

Labels

CI/CD CI/CD infrastructure cuda.bindings Everything related to the cuda.bindings module P1 Medium priority - Should do

Projects

None yet

Milestone

cuda-python 12.8.0 & 11.8.6

Development

Successfully merging this pull request may close these issues.

2 participants

@leofang @vzhurba01