Skip to content

Enable Cython tests for cuda.bindings #323

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
leofang merged 11 commits into from
Jan 6, 2025
Merged

Enable Cython tests for cuda.bindings #323

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
11a9063
enable Cython tests for cuda.bindings
leofang Dec 26, 2024
636bd19
build Cython test modules
leofang Dec 26, 2024
d208f3e
Update gh-build-and-test.yml
leofang Dec 26, 2024
e0c729c
Install system gcc
leofang Dec 26, 2024
2fbac68
No sudo
leofang Dec 27, 2024
371b318
also set CUDA_HOME
leofang Dec 27, 2024
7c5f9b9
Try to find Python include
leofang Dec 27, 2024
4e05ef2
nit: add a skip condition and comments
leofang Dec 27, 2024
0a9cb7d
Merge branch 'main' into enable_cython_test
leofang Dec 30, 2024
252a930
Merge branch 'main' into enable_cython_test
leofang Jan 3, 2025
a7f46ca
simplify
leofang Jan 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .github/actions/fetch_ctk/action.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -145,5 +145,6 @@ runs:
run: |
CUDA_PATH=$(realpath "./cuda_toolkit")
echo "CUDA_PATH=${CUDA_PATH}" >> $GITHUB_ENV
echo "CUDA_HOME=${CUDA_PATH}" >> $GITHUB_ENV
echo "${CUDA_PATH}/bin" >> $GITHUB_PATH
echo "LD_LIBRARY_PATH=${LD_LIBRARY_PATH:-}:${CUDA_PATH}/lib" >> $GITHUB_ENV
14 changes: 12 additions & 2 deletions .github/workflows/build-and-test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -285,6 +285,9 @@ jobs:
uses: actions/setup-python@v5
with:
python-version: ${{ matrix.python-version }}
env:
# we use self-hosted runners on which setup-python behaves weirdly...
AGENT_TOOLSDIRECTORY: "/opt/hostedtoolcache"

- name: Set up mini CTK
uses: ./.github/actions/fetch_ctk
Expand All @@ -306,8 +309,15 @@ jobs:
pushd ./cuda_bindings
pip install -r requirements.txt
pytest -rxXs tests/
# TODO: enable cython tests
#pytest tests/cython
if [[ "${{ matrix.host-platform }}" == linux* ]]; then
# cython tests require gcc
apt install -y build-essential
bash tests/cython/build_tests.sh
elif [[ "${{ matrix.host-platform }}" == win* ]]; then
# TODO: enable this once win-64 runners are up
exit 1
fi
pytest -rxXs tests/cython
popd

- name: Run cuda.core tests
Expand Down
Loading