Skip to content

Add a test for <nv/target> to validate old dialect support. #7241

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
wmaxey merged 10 commits into from
Feb 2, 2026
Merged

Add a test for <nv/target> to validate old dialect support. #7241

Show file tree
Hide file tree
Changes from 6 commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
afa3219
Add a test for <nv/target> to validate old dialect support.
wmaxey Jan 15, 2026
303c3fd
Check CMAKE_<LANG>_FEATURES for compatible standards
wmaxey Jan 21, 2026
b574a71
Merge branch 'main' into enh/nv_target_testing
wmaxey Jan 21, 2026
155aaea
spelling fixup
wmaxey Jan 21, 2026
d31d3b6
Check host compiler compatibility for CUDA as well
wmaxey Jan 27, 2026
b375963
Merge branch 'main' into enh/nv_target_testing
wmaxey Jan 27, 2026
3b0dafe
Merge remote-tracking branch 'origin/main' into enh/nv_target_testing
wmaxey Jan 28, 2026
0aad4d2
Rename target for nvtarget test
wmaxey Jan 28, 2026
ebccff7
[pre-commit.ci] auto code formatting
pre-commit-ci[bot] Jan 28, 2026
b46f4a1
Merge branch 'main' into enh/nv_target_testing
wmaxey Jan 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CMakePresets.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -361,6 +361,7 @@
"libcudacxx.test.public_headers",
"libcudacxx.test.public_headers_host_only",
"libcudacxx.test.lit.precompile",
"libcudacxx.test.nvtarget",
"libcudacxx.test.atomics.ptx",
"libcudacxx.test.c2h_all"
]
Expand Down
1 change: 1 addition & 0 deletions libcudacxx/test/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,4 +86,5 @@ if (LIBCUDACXX_TEST_WITH_NVRTC)
add_subdirectory(utils/nvidia/nvrtc)
endif()

add_subdirectory(nvtarget)
add_subdirectory(atomic_codegen)
41 changes: 41 additions & 0 deletions libcudacxx/test/nvtarget/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,41 @@
# This unit just checks that nv/target can be used with the specified dialects.

set(
nvtarget_dialects
11
14
17
20
)

set_directory_properties(
PROPERTIES
INCLUDE_DIRECTORIES "${libcudacxx_SOURCE_DIR}/include"
)
Comment on lines +5 to +7
Copy link
Contributor

@alliepiper alliepiper Jan 28, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Heads up that this API is a bit of a footgun and will clobber any existing directories rather than append. Prefer set_property(DIRECTORY APPEND PROPERTY ...) or include_directories(...).

For consistency with the rest of CCCL, can we move this to a target property?

Suggested change
set_directory_properties(
PROPERTIES
INCLUDE_DIRECTORIES "${libcudacxx_SOURCE_DIR}/include"
)

Copy link
Member Author

@wmaxey wmaxey Jan 28, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was kind of hoping for the clobbering behavior.


add_custom_target(libcudacxx.test.nvtarget)

foreach(dialect ${nvtarget_dialects})
if ("cxx_std_${dialect}" IN_LIST CMAKE_CXX_COMPILE_FEATURES)
add_library("nvtarget_cpp${dialect}" OBJECT nvtargettest.cpp)
# This is required to override CMAKE_CXX_STANDARD - target_compile_features is insufficient.
set_target_properties(
"nvtarget_cpp${dialect}" PROPERTIES
CXX_STANDARD "${dialect}"
CXX_STANDARD_REQUIRED ON
)
Copy link
Contributor

@alliepiper alliepiper Jan 28, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
)
)
target_include_directories(nvtarget_cpp${dialect} PRIVATE "${libcudacxx_SOURCE_DIR}/include")

add_dependencies(libcudacxx.test.nvtarget "nvtarget_cpp${dialect}")
endif()

if ("cuda_std_${dialect}" IN_LIST CMAKE_CUDA_COMPILE_FEATURES AND "cxx_std_${dialect}" IN_LIST CMAKE_CXX_COMPILE_FEATURES)
add_library("nvtarget_cuda${dialect}" OBJECT nvtargettest.cu)
# This is required to override CMAKE_CXX_STANDARD - target_compile_features is insufficient.
set_target_properties(
"nvtarget_cuda${dialect}" PROPERTIES
CUDA_STANDARD "${dialect}"
CUDA_STANDARD_REQUIRED ON
)
Copy link
Contributor

@alliepiper alliepiper Jan 28, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
)
)
target_include_directories(nvtarget_cuda${dialect} PRIVATE "${libcudacxx_SOURCE_DIR}/include")

add_dependencies(libcudacxx.test.nvtarget "nvtarget_cuda${dialect}")
endif()

endforeach()
6 changes: 6 additions & 0 deletions libcudacxx/test/nvtarget/nvtargettest.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
#include <nv/target>

int main()
{
return 0;
}
6 changes: 6 additions & 0 deletions libcudacxx/test/nvtarget/nvtargettest.cu
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
#include <nv/target>

int main()
{
return 0;
}