[DOCS] Clarifies DeviceTopK docs that inputs and output ranges may not overlap#7078
Merged
elstehle merged 1 commit intoNVIDIA:mainfrom Jan 5, 2026
Merged
Conversation
Contributor
🥳 CI Workflow Results🟩 Finished in 1h 22m: Pass: 100%/95 | Total: 1d 09h | Max: 1h 22m | Hits: 97%/89371See results here. |
| //! | ||
| //! Finds the largest K keys and their corresponding values from an unordered input sequence of key-value pairs. | ||
| //! - Finds the largest K keys and their corresponding values from an unordered input sequence of key-value pairs. | ||
| //! - Note that the behavior is undefined if the input and output ranges overlap in any way. |
Contributor
There was a problem hiding this comment.
Suggestion: let's not call it a "note":
Suggested change
| //! - Note that the behavior is undefined if the input and output ranges overlap in any way. | |
| //! - The behavior is undefined if the input and output ranges overlap in any way. |
or:
Suggested change
| //! - Note that the behavior is undefined if the input and output ranges overlap in any way. | |
| //! - The input and output ranges must not overlap in any way. |
Applies to all comments.
bernhardmgruber
approved these changes
Jan 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since
DeviceTopKis a multi-pass algorithm, user-provided inputs and output ranges may not overlap.