Skip to content

[libcu++] Add explicit alignment specification in buffer#7005

Merged
pciolkosz merged 5 commits intoNVIDIA:mainfrom
pciolkosz:add_explicit_alignment_in_buffer
Dec 19, 2025
Merged

[libcu++] Add explicit alignment specification in buffer#7005
pciolkosz merged 5 commits intoNVIDIA:mainfrom
pciolkosz:add_explicit_alignment_in_buffer

Conversation

@pciolkosz
Copy link
Contributor

We should explicitly pass alignment of the stored type into allocate instead of relying on the default.
We currently have no way to specify a different alignment requirement, but a future change will add it

@pciolkosz pciolkosz requested a review from a team as a code owner December 17, 2025 23:48
@pciolkosz pciolkosz requested a review from fbusato December 17, 2025 23:48
@github-project-automation github-project-automation bot moved this to Todo in CCCL Dec 17, 2025
@cccl-authenticator-app cccl-authenticator-app bot moved this from Todo to In Review in CCCL Dec 17, 2025
@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions
Copy link
Contributor

🥳 CI Workflow Results

🟩 Finished in 12h 27m: Pass: 100%/91 | Total: 1d 01h | Max: 1h 24m | Hits: 96%/217741

See results here.

@pciolkosz pciolkosz merged commit 7e6770d into NVIDIA:main Dec 19, 2025
198 of 203 checks passed
@github-project-automation github-project-automation bot moved this from In Review to Done in CCCL Dec 19, 2025
@github-actions
Copy link
Contributor

Backport failed for branch/3.2.x, because it was unable to cherry-pick the commit(s).

Please cherry-pick the changes locally and resolve any conflicts.

git fetch origin branch/3.2.x
git worktree add -d .worktree/backport-7005-to-branch/3.2.x origin/branch/3.2.x
cd .worktree/backport-7005-to-branch/3.2.x
git switch --create backport-7005-to-branch/3.2.x
git cherry-pick -x 7e6770d30df6b917ee213a9889ab0fafa426ecef

pciolkosz added a commit to pciolkosz/cccl that referenced this pull request Dec 19, 2025
* Add explicit alignment specification in buffer

* Fix shared resource test

* Missed alignment in deallocate

(cherry picked from commit 7e6770d)
fbusato pushed a commit to fbusato/cccl that referenced this pull request Dec 23, 2025
* Add explicit alignment specification in buffer

* Fix shared resource test

* Missed alignment in deallocate
bernhardmgruber pushed a commit that referenced this pull request Jan 2, 2026
* Add explicit alignment specification in buffer
* Fix shared resource test
* Missed alignment in deallocate

(cherry picked from commit 7e6770d)

Co-authored-by: Leo Fang <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

2 participants