Remove [[nodiscard]] from barrier's .arrive(...) method#6947
Merged
davebayer merged 3 commits intoNVIDIA:mainfrom Dec 11, 2025
Merged
Remove [[nodiscard]] from barrier's .arrive(...) method#6947davebayer merged 3 commits intoNVIDIA:mainfrom
[[nodiscard]] from barrier's .arrive(...) method#6947davebayer merged 3 commits intoNVIDIA:mainfrom
Conversation
davebayer
added
backport branch/3.0.x
backport branch/3.1.x
backport branch/3.2.x
and removed
backport branch/3.0.x
labels
miscco
reviewed
Dec 11, 2025
miscco
approved these changes
Dec 11, 2025
davebayer
changed the title
[[nodiscard}} from barrier's .arrive(...) method[[nodiscard]] from barrier's .arrive(...) method
Contributor
🥳 CI Workflow Results🟩 Finished in 3h 11m: Pass: 100%/91 | Total: 1d 07h | Max: 1h 14m | Hits: 97%/206562See results here. |
Contributor
|
Backport failed for Please cherry-pick the changes locally and resolve any conflicts. git fetch origin branch/3.1.x
git worktree add -d .worktree/backport-6947-to-branch/3.1.x origin/branch/3.1.x
cd .worktree/backport-6947-to-branch/3.1.x
git switch --create backport-6947-to-branch/3.1.x
git cherry-pick -x 9ddee1cfc58fa90d0e6f1ca0c556b2e475150b46 |
github-actions bot
pushed a commit
that referenced
this pull request
Dec 11, 2025
(cherry picked from commit 9ddee1c)
Contributor
|
Successfully created backport PR for |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #6943, removes superfluous
inlines, adds missing[[nodiscard]]to.try_wait_meow()methods and fixes__try_wait_parityUB.