Make sure we actually use overflow builtins#6904
Merged
davebayer merged 3 commits intoNVIDIA:mainfrom Dec 10, 2025
Merged
Conversation
miscco
approved these changes
Dec 8, 2025
Comment on lines
+47
to
+49
| #if _CCCL_CHECK_BUILTIN(builtin_add_overflow) || _CCCL_COMPILER(GCC) | ||
| # define _CCCL_BUILTIN_ADD_OVERFLOW(...) __builtin_add_overflow(__VA_ARGS__) | ||
| #endif // _CCCL_CHECK_BUILTIN(__builtin_add_overflow) | ||
| #endif // _CCCL_CHECK_BUILTIN(builtin_add_overflow) |
davebayer
force-pushed
the
fix_check_builtin
branch
from
047b74f to
7c82f2e
Compare
This comment has been minimized.
This comment has been minimized.
davebayer
force-pushed
the
fix_check_builtin
branch
from
7c82f2e to
d0a385f
Compare
This comment has been minimized.
This comment has been minimized.
Contributor
🥳 CI Workflow Results🟩 Finished in 5h 00m: Pass: 100%/91 | Total: 1d 18h | Max: 3h 14m | Hits: 99%/195470See results here. |
github-actions bot
pushed a commit
that referenced
this pull request
Dec 10, 2025
(cherry picked from commit 6d2f46e)
Contributor
|
Successfully created backport PR for |
davebayer
added a commit
that referenced
this pull request
Dec 13, 2025
(cherry picked from commit 6d2f46e) Co-authored-by: David Bayer <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We should be careful about removing the
__prefix when detecting builtins by_CCCL_CHECK_BUILTIN(...)..I've also found some bugs in 13.1
__builtin_add_overflowand__builtin_sub_overflowimplementation (nvbug 5724197).