Replace internal assert with _CCCL_ASSERT in libcu++#6825
Merged
davebayer merged 1 commit intoNVIDIA:mainfrom Dec 2, 2025
Merged
Replace internal assert with _CCCL_ASSERT in libcu++#6825davebayer merged 1 commit intoNVIDIA:mainfrom
assert with _CCCL_ASSERT in libcu++#6825davebayer merged 1 commit intoNVIDIA:mainfrom
Conversation
fbusato
approved these changes
Dec 1, 2025
| case __ATOMIC_ACQ_REL: [[fallthrough]]; | ||
| case __ATOMIC_RELEASE: __cuda_atomic_fence(_Sco{}, __atomic_cuda_acq_rel{}); break; | ||
| case __ATOMIC_RELAXED: break; | ||
| default: assert(0); |
Contributor
There was a problem hiding this comment.
assert(0) sounds like the path is never reached rather than a real assertion. Anyway, that's fine for this PR
Contributor
Author
There was a problem hiding this comment.
Would you prefer _CCCL_UNREACHABLE() in this case?
Contributor
There was a problem hiding this comment.
_CCCL_UNREACHABLE should be the right solution but it doesn't provide any debug info. I already tried to improve it but I didn't want to spent time on this #4460
This comment has been minimized.
This comment has been minimized.
davebayer
force-pushed
the
replace_assert
branch
from
7ee4e76 to
dae7052
Compare
Contributor
🥳 CI Workflow Results🟩 Finished in 1h 17m: Pass: 100%/90 | Total: 1d 06h | Max: 1h 17m | Hits: 91%/214635See results here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.