Enable caching of advance/dereference methods for Zipiterator and PermutationIterator#6753
Merged
shwina merged 3 commits intoNVIDIA:mainfrom Nov 24, 2025
Merged
Conversation
Contributor
🥳 CI Workflow Results🟩 Finished in 1h 03m: Pass: 100%/48 | Total: 11h 28m | Max: 39m 51sSee results here. |
NaderAlAwar
approved these changes
Nov 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Creating
ZipIteratorandPermutationIteratorobjects is expensive - involving dynamic code generation viaexec, This PR enables caching of the generatedadvanceanddereferencemethods.It also moves the implementation of
ZipIteratorinto_zip_iterator.py.Checklist