Merged
Conversation
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
davebayer
force-pushed
the
sincos
branch
2 times, most recently
from
419077d to
05730ed
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
s-oboyle
reviewed
Nov 24, 2025
s-oboyle
reviewed
Nov 24, 2025
Contributor
Author
|
@s-oboyle I've applied the function to even more places, could you confirm it is fine? |
davebayer
commented
Nov 24, 2025
davebayer
commented
Nov 24, 2025
This comment has been minimized.
This comment has been minimized.
fbusato
requested changes
Nov 24, 2025
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Contributor
🥳 CI Workflow Results🟩 Finished in 1h 21m: Pass: 100%/90 | Total: 1d 08h | Max: 1h 19m | Hits: 99%/201139See results here. |
fbusato
approved these changes
Dec 1, 2025
| #endif // _LIBCUDACXX_HAS_NVFP16() | ||
|
|
||
| #if _LIBCUDACXX_HAS_NVBF16() | ||
| __host__ __device__ bool is_about(__nv_bfloat16 x, __nv_bfloat16 y) |
Contributor
There was a problem hiding this comment.
I always think that one day we should provide these functions in libcu++ because they are used practically everywhere
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If once wants to compute sin and cos of a number, computing both operations at the same time allows some optimizations.
This PR introduces
cuda::sincosthat tries to use compiler builtins and device intrinsics to provide this functionality and fallbacks to separate sin and cos calculation.