Refactor mdspan cuda::std::__detectably_invalid#6733
Merged
fbusato merged 29 commits intoNVIDIA:mainfrom Jan 8, 2026
Merged
Conversation
is_pointer_accessible to mdspanis_pointer_accessible to mdspan
This comment has been minimized.
This comment has been minimized.
davebayer
requested changes
Nov 22, 2025
Co-authored-by: David Bayer <[email protected]>
Co-authored-by: David Bayer <[email protected]>
Co-authored-by: David Bayer <[email protected]>
Contributor
Author
|
@davebayer @miscco I'm starting thinking that we are doing the wrong thing for host/device/managed.
Ideally,
|
This comment has been minimized.
This comment has been minimized.
bernhardmgruber
approved these changes
Nov 25, 2025
2 tasks
This comment has been minimized.
This comment has been minimized.
davebayer
requested changes
Dec 8, 2025
Co-authored-by: David Bayer <[email protected]>
Co-authored-by: David Bayer <[email protected]>
is_pointer_accessible to mdspancuda::std::__detectably_invalid
cuda::std::__detectably_invalidmdspan cuda::std::__detectably_invalid
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
davebayer
approved these changes
Jan 5, 2026
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
miscco
reviewed
Jan 6, 2026
| // - Direct-non-list-initializes ptr_ with cuda::std::move(p), | ||
| // - direct-non-list-initializes map_ with ext, and | ||
| // - value-initializes acc_. | ||
| #define _CCCL_DISABLE_MDSPAN_ACCESSOR_DETECT_INVALIDITY |
Contributor
Author
There was a problem hiding this comment.
it is very hard to reimplement all tests to work with the right accessor respect to the memory space.
I added this macro to disable the checks
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Contributor
🥳 CI Workflow Results🟩 Finished in 2h 10m: Pass: 100%/84 | Total: 1d 12h | Max: 1h 48m | Hits: 86%/197813See results here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Replace old code in host/device/managed mdspan with https://nvidia.github.io/cccl/libcudacxx/extended_api/memory/is_pointer_accessible.html