Skip to content

Improve and apply _CCCL_THROW #6684

Merged
fbusato merged 27 commits intoNVIDIA:mainfrom
fbusato:cccl-throw-if
Dec 13, 2025
Merged

Improve and apply _CCCL_THROW #6684
fbusato merged 27 commits intoNVIDIA:mainfrom
fbusato:cccl-throw-if

Conversation

@fbusato
Copy link
Contributor

@fbusato fbusato commented Nov 19, 2025

Description

The CCCL host API should use the exception mechanism to report errors.

Changes introduced by this PR:

  • Adds _CCCL_THROW_IF to throw an exception when preconditions are not meet.
  • Applies _CCCL_THROW_IF to make_tma_descriptor to replace _CCCL_VERIFY.

@fbusato fbusato self-assigned this Nov 19, 2025
@fbusato fbusato requested a review from a team as a code owner November 19, 2025 00:08
@fbusato fbusato added the 3.2.0 label Nov 19, 2025
@fbusato fbusato requested a review from a team as a code owner November 19, 2025 00:08
@fbusato fbusato added this to CCCL Nov 19, 2025
@github-project-automation github-project-automation bot moved this to Todo in CCCL Nov 19, 2025
@cccl-authenticator-app cccl-authenticator-app bot moved this from Todo to In Review in CCCL Nov 19, 2025
@github-actions

This comment has been minimized.

@jrhemstad jrhemstad requested a review from pciolkosz November 19, 2025 02:35
@github-project-automation github-project-automation bot moved this from In Review to In Progress in CCCL Nov 19, 2025
@davebayer
Copy link
Contributor

Also, docs update is missing

@github-actions

This comment has been minimized.

@fbusato fbusato requested a review from davebayer November 21, 2025 17:15
@github-actions

This comment has been minimized.

@fbusato fbusato requested a review from miscco November 24, 2025 19:44
@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

Copy link
Contributor

@davebayer davebayer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have a mixed feelings about this, I'd like to have another opinion whether this is an improvement.

@miscco could you review this, please?

@fbusato fbusato moved this from In Progress to In Review in CCCL Dec 3, 2025
@fbusato
Copy link
Contributor Author

fbusato commented Dec 8, 2025

@davebayer I replaced all _CCCL_THROW_IF with if + _CCCL_THROW. If the result is nicer, I'm also fine with removing _CCCL_THROW_IF entirely

@fbusato fbusato requested a review from davebayer December 8, 2025 23:23
@github-actions

This comment has been minimized.

Copy link
Contributor

@davebayer davebayer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I think this better. @miscco what do you think?

@fbusato fbusato requested a review from davebayer December 12, 2025 18:44
@fbusato fbusato enabled auto-merge (squash) December 12, 2025 18:44
@fbusato fbusato changed the title Add _CCCL_THROW_IF Improve and apply _CCCL_THROW Dec 12, 2025
@github-actions

This comment has been minimized.

@github-actions
Copy link
Contributor

🥳 CI Workflow Results

🟩 Finished in 7h 54m: Pass: 100%/91 | Total: 2d 06h | Max: 2h 57m | Hits: 91%/209892

See results here.

@fbusato fbusato merged commit e5ed71c into NVIDIA:main Dec 13, 2025
184 of 206 checks passed
@github-project-automation github-project-automation bot moved this from In Review to Done in CCCL Dec 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

4 participants