Check for __cpp_xxx value, not definition#4811
Merged
davebayer merged 1 commit intoNVIDIA:mainfrom Feb 3, 2026
Merged
Conversation
Contributor
miscco
approved these changes
May 27, 2025
Contributor
miscco
left a comment
There was a problem hiding this comment.
@ericniebler any objections?
Contributor
|
/ok to test 6c418a6 |
Contributor
🟩 CI finished in 1h 58m: Pass: 100%/183 | Total: 1d 21h | Avg: 14m 54s | Max: 1h 36m | Hits: 89%/291249
|
| Project | |
|---|---|
| CCCL Infrastructure | |
| +/- | libcu++ |
| CUB | |
| +/- | Thrust |
| +/- | CUDA Experimental |
| stdpar | |
| python | |
| CCCL C Parallel Library | |
| Catch2Helper |
Modifications in project or dependencies?
| Project | |
|---|---|
| CCCL Infrastructure | |
| +/- | libcu++ |
| +/- | CUB |
| +/- | Thrust |
| +/- | CUDA Experimental |
| +/- | stdpar |
| +/- | python |
| +/- | CCCL C Parallel Library |
| +/- | Catch2Helper |
🏃 Runner counts (total jobs: 183)
| # | Runner |
|---|---|
| 129 | linux-amd64-cpu16 |
| 15 | windows-amd64-cpu16 |
| 12 | linux-arm64-cpu16 |
| 12 | linux-amd64-gpu-rtxa6000-latest-1 |
| 7 | linux-amd64-gpu-rtx2080-latest-1 |
| 5 | linux-amd64-gpu-h100-latest-1 |
| 3 | linux-amd64-gpu-rtx4090-latest-1 |
ericniebler
reviewed
Jun 2, 2025
Contributor
ericniebler
left a comment
There was a problem hiding this comment.
if we're changing this, i would rather we always test the version test macros against a specific (non-zero) value.
Contributor
|
/ok to test c579a5d |
Contributor
🟩 CI finished in 2h 06m: Pass: 100%/130 | Total: 1d 11h | Avg: 16m 24s | Max: 1h 41m | Hits: 89%/162899
|
| Project | |
|---|---|
| CCCL Infrastructure | |
| CCCL Packaging | |
| libcu++ | |
| CUB | |
| +/- | Thrust |
| +/- | CUDA Experimental |
| stdpar | |
| python | |
| CCCL C Parallel Library | |
| Catch2Helper |
Modifications in project or dependencies?
| Project | |
|---|---|
| CCCL Infrastructure | |
| +/- | CCCL Packaging |
| libcu++ | |
| +/- | CUB |
| +/- | Thrust |
| +/- | CUDA Experimental |
| +/- | stdpar |
| python | |
| +/- | CCCL C Parallel Library |
| +/- | Catch2Helper |
🏃 Runner counts (total jobs: 130)
| # | Runner |
|---|---|
| 89 | linux-amd64-cpu16 |
| 11 | windows-amd64-cpu16 |
| 10 | linux-arm64-cpu16 |
| 7 | linux-amd64-gpu-rtx2080-latest-1 |
| 6 | linux-amd64-gpu-rtxa6000-latest-1 |
| 4 | linux-amd64-gpu-h100-latest-1 |
| 3 | linux-amd64-gpu-rtx4090-latest-1 |
f956c29 to
49fc2f7
Compare
Contributor
|
/ok to test 49fc2f7 |
miscco
approved these changes
Jun 13, 2025
Contributor
miscco
left a comment
There was a problem hiding this comment.
I need to go through all of them, what I am worried about are those feature macros that have different values
Contributor
🟩 CI finished in 1h 58m: Pass: 100%/183 | Total: 2d 06h | Avg: 17m 50s | Max: 1h 39m | Hits: 76%/294220
|
| Project | |
|---|---|
| CCCL Infrastructure | |
| CCCL Packaging | |
| +/- | libcu++ |
| CUB | |
| +/- | Thrust |
| +/- | CUDA Experimental |
| stdpar | |
| python | |
| CCCL C Parallel Library | |
| Catch2Helper |
Modifications in project or dependencies?
| Project | |
|---|---|
| CCCL Infrastructure | |
| +/- | CCCL Packaging |
| +/- | libcu++ |
| +/- | CUB |
| +/- | Thrust |
| +/- | CUDA Experimental |
| +/- | stdpar |
| +/- | python |
| +/- | CCCL C Parallel Library |
| +/- | Catch2Helper |
🏃 Runner counts (total jobs: 183)
| # | Runner |
|---|---|
| 125 | linux-amd64-cpu16 |
| 15 | windows-amd64-cpu16 |
| 12 | linux-arm64-cpu16 |
| 12 | linux-amd64-gpu-rtxa6000-latest-1 |
| 11 | linux-amd64-gpu-rtx2080-latest-1 |
| 5 | linux-amd64-gpu-h100-latest-1 |
| 3 | linux-amd64-gpu-rtx4090-latest-1 |
49fc2f7 to
842c680
Compare
Contributor
🥳 CI Workflow Results🟩 Finished in 4h 09m: Pass: 100%/184 | Total: 6d 16h | Max: 4h 09m | Hits: 72%/380949See results here. |
fbusato
pushed a commit
to fbusato/cccl
that referenced
this pull request
Feb 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If undefined, the symbol will expand to
0anyway. This PR also replaces some use of__cpp_char8_twith_CCCL_HAS_CHAR8_T().