update doc with latest DIA support#983
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
Updates the sparse tensor documentation to reflect new DIA format support and an expanded constructor interface.
- Extend
solvedocumentation to include tri-DIA support. - Revise
make_tensor_diacomment to describe index-based padding and add anIDXtemplate parameter. - Update function signature to accept the new
IDXparameter.
Comments suppressed due to low confidence (2)
docs_input/basics/sparse_tensor.rst:145
- [nitpick] Replace the abbreviation "vv." with "vice versa" to avoid ambiguity in the comment.
// is vv. when using index J. This format is most efficient for matrices with
docs_input/basics/sparse_tensor.rst:147
- [nitpick] The new template parameter
IDXisn't described in the preceding comment; consider documenting its purpose or renaming it (e.g.,IndexType) for better clarity.
template <typename IDX, typename ValTensor, typename CrdTensor>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Collaborator
|
/build |
cliffburdick
approved these changes
Jun 3, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.