Skip to content

Add Fusion.print, which prints the transforms as well as the math #5499

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add Fusion.print, which prints the transforms as well as the math #5499

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions python/python_direct/runtime.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -186,6 +186,16 @@ Returns
-------
str
The fusion intermediate representation (IR) as a string.
)")
.def(
"print",
[](Fusion& f) { f.print(std::cout); },
Copy link
Contributor

@greptile-apps greptile-apps bot Nov 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

style: inconsistent return behavior - print_math and print_kernel both return strings by capturing output in a stringstream, but this new print method prints directly to stdout and returns None. Consider making it consistent:

Suggested change
[](Fusion& f) { f.print(std::cout); },
[](Fusion& f) {
std::stringstream ss;
DebugStreamGuard dsg(ss);
f.print(ss);
return ss.str();
},

R"(
Print the fusion, including transforms, to stdout.

Returns
-------
None
Copy link
Collaborator Author

@wujingyue wujingyue Nov 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I saw other print_*s return a string instead. I personally found it confusing to have to type print twice, but let me know what you think. One option may be to have an __str__.

Copy link
Collaborator

@rdspring1 rdspring1 Nov 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Returning a string is nice, so you can search through it in tests.
I thought about renaming print_* to something more clear, since string are returned instead being printed to stdout.

You could map CPP print to __repr__ since it is more verbose than print_math. Then, do print(repr(fd.fusion)).

)")
.def(
"print_kernel",
Expand Down