Skip to content

Update third-party dependencies (2026-03-25)#156

Open
szalpal wants to merge 5 commits intoNVIDIA:mainfrom
szalpal:deps-update/2026-03-25
Open

Update third-party dependencies (2026-03-25)#156
szalpal wants to merge 5 commits intoNVIDIA:mainfrom
szalpal:deps-update/2026-03-25

Conversation

@szalpal
Copy link
Copy Markdown
Member

@szalpal szalpal commented Mar 25, 2026

Updated dependencies

  • opus: 1.5.2 → 1.6.1
  • FFmpeg: 8.0.1 → 8.1
  • protobuf: 34.0 → 34.1
  • curl: 8.18.0 → 8.19.0
  • aws-sdk-cpp: 1.11.760 → 1.11.776

Test plan

  • CI passes (lint + build)
  • Verify updated libraries build correctly with build_deps.sh

szalpal added 5 commits March 25, 2026 14:03
Signed-off-by: szalpal <mszolucha@nvidia.com>
Signed-off-by: szalpal <mszolucha@nvidia.com>
Signed-off-by: szalpal <mszolucha@nvidia.com>
Signed-off-by: szalpal <mszolucha@nvidia.com>
Signed-off-by: szalpal <mszolucha@nvidia.com>
@greptile-apps
Copy link
Copy Markdown

greptile-apps bot commented Mar 25, 2026

Greptile Summary

This PR performs routine bumps of five third-party submodule dependencies — opus (1.5.2→1.6.1), FFmpeg (8.0.1→8.1), protobuf (34.0→34.1), curl (8.18.0→8.19.0), and aws-sdk-cpp (1.11.760→1.11.776) — and updates the corresponding version table in README.rst. All build scripts under build_scripts/ reference submodule directories directly (with no hardcoded version strings), so no script changes are needed.

Key observations:

  • All five submodule commit pointers are updated consistently with the declared version changes in the README
  • build_libopus.sh dynamically parses README.rst with a grep/grep -Eo pipeline to derive the opus git tag before building — the new v1.6.1 entry is correctly picked up by this mechanism
  • The FFmpeg version string shortened from 8.0.1 to 8.1 (4 fewer characters total across the link text and URL). RST grid tables require | separators to be at consistent column positions across all rows; the trailing spaces on the two FFmpeg rows should be verified/padded to avoid a rendering regression

Confidence Score: 5/5

  • This PR is safe to merge; it is a straightforward set of submodule version bumps with consistent README updates and no build-script changes required.
  • All changes are mechanical: submodule pointers advanced to new upstream tags, README version table updated to match. No logic or build-script modifications were needed, and none were made incorrectly. The only open item is a cosmetic RST table padding concern on the FFmpeg rows that does not affect runtime correctness.
  • README.rst — verify FFmpeg row column padding is consistent with the rest of the grid table after the version string shortening.

Important Files Changed

Filename Overview
README.rst Version table updated for all 5 dependencies; FFmpeg row has slightly reduced column padding due to shorter version string (8.1 vs 8.0.1), which may cause RST grid table misalignment.
third_party/FFmpeg Submodule pointer bumped from commit 894da5c (n8.0.1) to 9047fa1 (n8.1); no other changes required as build_ffmpeg.sh uses the submodule directory directly.
third_party/opus Submodule pointer bumped from ddbe483 (v1.5.2) to 22244de (v1.6.1); build_libopus.sh dynamically parses the README.rst for the version tag, so no extra changes needed.
third_party/protobuf Submodule pointer bumped from 6a6cd88 (v34.0) to 4b0c3aa (v34.1); build_protobuf.sh has no hardcoded version strings so no further changes required.
third_party/curl Submodule pointer bumped from 2eebc58 (8.18.0) to 8c908d2 (8.19.0); build_aws-sdk-cpp.sh references the submodule directory directly, no version string changes needed.
third_party/aws-sdk-cpp Submodule pointer bumped from b7e4f68 (1.11.760) to c9dd965 (1.11.776); build script is version-agnostic.

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    A[PR: Update third-party deps] --> B[README.rst\nVersion table updated]
    A --> C[third_party/opus\nv1.5.2 → v1.6.1]
    A --> D[third_party/FFmpeg\nn8.0.1 → n8.1]
    A --> E[third_party/protobuf\nv34.0 → v34.1]
    A --> F[third_party/curl\n8.18.0 → 8.19.0]
    A --> G[third_party/aws-sdk-cpp\n1.11.760 → 1.11.776]

    C --> H[build_libopus.sh\nParses README.rst for tag\nNo version hardcoding]
    D --> I[build_ffmpeg.sh\nUses submodule dir directly\nNo version hardcoding]
    E --> J[build_protobuf.sh\nUses submodule dir directly\nNo version hardcoding]
    F --> K[build_aws-sdk-cpp.sh\nUses submodule dir directly\nNo version hardcoding]
    G --> K
Loading

Reviews (1): Last reviewed commit: "Update aws-sdk-cpp to 1.11.776" | Re-trigger Greptile

Comment on lines +30 to +31
| `FFmpeg <https://github.com/FFmpeg/FFmpeg>`_ | `8.1 <https://github.com/FFmpeg/FFmpeg/releases/tag/n8.1>`_ | `LGPL v2.1 license <https://github.com/FFmpeg/FFmpeg/blob/master/LICENSE.md>`_ |
| | `(Source Snapshot) <https://developer.download.nvidia.com/compute/redist/nvidia-dali/FFmpeg-n8.1.tar.gz>`_ | |
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 RST grid table column width misalignment

The FFmpeg version string changed from 8.0.1 (5 chars) to 8.1 (3 chars), and the URL fragment from n8.0.1 (6 chars) to n8.1 (4 chars) — a total of 4 fewer characters per cell across both the version link and the source snapshot URL. In RST grid tables, every | separator must land in the same column position across all rows. If the trailing spaces in these two lines weren't padded out by 4 extra spaces to compensate, the column borders will be misaligned and the table will fail to render correctly.

Please verify that the | character closing the second column still sits at the same horizontal position as in all other rows (e.g. compare against the libsndfile or curl rows), and add trailing spaces to both lines if needed:

Suggested change
| `FFmpeg <https://github.com/FFmpeg/FFmpeg>`_ | `8.1 <https://github.com/FFmpeg/FFmpeg/releases/tag/n8.1>`_ | `LGPL v2.1 license <https://github.com/FFmpeg/FFmpeg/blob/master/LICENSE.md>`_ |
| | `(Source Snapshot) <https://developer.download.nvidia.com/compute/redist/nvidia-dali/FFmpeg-n8.1.tar.gz>`_ | |
| `FFmpeg <https://github.com/FFmpeg/FFmpeg>`_ | `8.1 <https://github.com/FFmpeg/FFmpeg/releases/tag/n8.1>`_ | `LGPL v2.1 license <https://github.com/FFmpeg/FFmpeg/blob/master/LICENSE.md>`_ |
| | `(Source Snapshot) <https://developer.download.nvidia.com/compute/redist/nvidia-dali/FFmpeg-n8.1.tar.gz>`_ | |

@mdabek-nvidia
Copy link
Copy Markdown
Collaborator

Make sure to update the internal docs to reflect the update

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants