Open
Conversation
Signed-off-by: Michał Szołucha <mszolucha@nvidia.com>
Greptile SummaryThis PR adds a
Confidence Score: 5/5
Important Files Changed
Flowchart%%{init: {'theme': 'neutral'}}%%
flowchart TD
A[Clone repo] --> B[git submodule init]
B --> C[git submodule update --depth 1 --recursive]
C --> D{Build target?}
D -- All deps --> E[Set env vars\nHOST_INSTALL_PREFIX, CC_COMP, etc.]
E --> F[bash -ex build_scripts/build_deps.sh]
F --> G[Iterates PACKAGE_LIST\nzlib → protobuf → lmdb → ... → aws-sdk-cpp]
G --> H[Each build_xxx.sh script\napplies patches/ if needed]
D -- Single dep --> I[bash -ex build_scripts/build_opencv.sh\nor build_ffmpeg.sh, etc.]
I --> H
H --> J[Installed to INSTALL_PREFIX]
K[CLEANUP=1] -.-> |git clean root + submodules\nreinit + force-checkout| C
Last reviewed commit: 50b8001 |
| - `CC_COMP` / `CXX_COMP` — compiler selection (default `gcc`/`g++`) | ||
| - `CMAKE_TARGET_ARCH` — target architecture (default: host arch) | ||
| - `WITH_FFMPEG` — set to `0` to skip FFmpeg (default `1`) | ||
| - `CLEANUP=1` — runs `git clean -fdx` on all submodules before building |
There was a problem hiding this comment.
CLEANUP description slightly incomplete
CLEANUP=1 does more than clean submodule working trees. Looking at build_scripts/build_deps.sh, it actually:
- Runs
git clean -fdxon the root repo itself - Re-runs
git submodule initandgit submodule update --init --recursive - Runs
git submodule foreach 'git clean -fdx'on each submodule - Runs
git submodule foreach 'git checkout --force'
The current description implies only submodule cleaning, which could mislead a reader into thinking the root working tree is unaffected. Consider:
Suggested change
| - `CLEANUP=1` — runs `git clean -fdx` on all submodules before building | |
| - `CLEANUP=1` — runs `git clean -fdx` on the root repo and all submodules, re-initialises submodules, and force-checks them out before building |
mdabek-nvidia
approved these changes
Mar 23, 2026
stiepan
approved these changes
Mar 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds CLAUDE.md to the repository