-
Notifications
You must be signed in to change notification settings - Fork 3.4k
Add functional tests for init, train step, and inference for every supported released model #15433
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 9 commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
9bd4767
Add functional tests for all supported NeMo speech models
pzelasko 122af95
Split up the functional tests into separate files
pzelasko 1dd0378
Fix all 15 failing model training step tests (80/80 pass)
pzelasko 558ae87
remove test reading csv file
pzelasko ff7f815
model registry json
pzelasko 7100512
remove numba workaround
pzelasko aad889d
Merge branch 'main' into model-support-functional-tests
pzelasko 4958efe
fix lint
pzelasko 408ae1a
Exclude functional tests from Unit_Test_X_Others
pzelasko 9b5cd89
Merge branch 'main' into model-support-functional-tests
pzelasko 67b05f0
Address review, fix specific tests
pzelasko eace8eb
Merge branch 'main' into model-support-functional-tests
pzelasko 4183cf0
Conversion of the new tests to e2e_nightly + register them in Github …
pzelasko e0e5621
Revert change
pzelasko File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@pzelasko regarding scheduling this, we actually run nightly tests on main branch already. Looks like one of the CI tests needs to be fixed.
https://github.com/NVIDIA-NeMo/NeMo/actions/runs/22421911989
https://github.com/NVIDIA-NeMo/NeMo/blob/main/.github/workflows/cicd-main.yml#L17
In any case, to separate these out to run nightly only, it may be better to move the tests to a new group called
e2e-nightlyor whatever you want on it and apply a condition like this:https://github.com/NVIDIA-NeMo/NeMo/blob/main/.github/workflows/cicd-main.yml#L246
The condition could be something like:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@chtruong814 added, can you check if it looks OK? Thanks!