Bump to pytorch 25.11 by chtruong814 · Pull Request #15247 · NVIDIA-NeMo/NeMo

chtruong814 · 2026-01-01T16:27:34Z

What does this PR do ?

Bump to pytorch 25.11

Collection: [Note which collection this PR will affect]

Changelog

Add specific line by line info of high level changes in this PR.

Usage

You can potentially add a usage example below

# Add a code snippet demonstrating how to use this

GitHub Actions CI

The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.

The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".

Before your PR is "Ready for review"

Pre checks:

Make sure you read and followed Contributor guidelines
Did you write any new necessary tests?
Did you add or update any necessary documentation?
Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- Reviewer: Does the PR have correct import guards for all optional libraries?

PR Type:

New Feature
Bugfix
Documentation

If you haven't finished some of the above items you can still open "Draft" PR.

Who can review?

Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.

Additional Information

Related to # (issue)

Signed-off-by: Charlie Truong <chtruong@nvidia.com>

Signed-off-by: chtruong814 <chtruong814@users.noreply.github.com>

Signed-off-by: Charlie Truong <chtruong@nvidia.com>

Signed-off-by: chtruong814 <chtruong814@users.noreply.github.com>

Signed-off-by: Charlie Truong <chtruong@nvidia.com>

github-actions · 2026-01-07T06:51:01Z

[🤖]: Hi @chtruong814 👋,

We wanted to let you know that a CICD pipeline for this PR just finished successfully.

So it might be time to merge this PR or get some approvals.

//cc @chtruong814 @ko3n1g @pablo-garay @thomasdhc

This reverts commit 8acdc2b. Signed-off-by: Charlie Truong <chtruong@nvidia.com>

This reverts commit bb3412e. Signed-off-by: Charlie Truong <chtruong@nvidia.com>

github-actions · 2026-01-08T04:50:15Z

[🤖]: Hi @chtruong814 👋,

We wanted to let you know that a CICD pipeline for this PR just finished successfully.

So it might be time to merge this PR or get some approvals.

//cc @chtruong814 @ko3n1g @pablo-garay @thomasdhc

nithinraok · 2026-01-09T17:00:49Z

nemo/collections/common/data/lhotse/__init__.py

+# Newer versions of torch.utils.data.Sampler do not have the data_source parameter.
+# lhotse's CutSampler expects to pass data_source to Sampler, so we need to patch
+# Sampler.__init__ to accept it.
+if "data_source" not in inspect.signature(Sampler.__init__).parameters:
+
+    def patched_sampler_init(self, data_source=None):
+        pass
+
+    Sampler.__init__ = patched_sampler_init


@chtruong814 How urgent is it to merge this PR? I can release a new lhotse version tested against latest pytorch so that this patch is not needed.

We're going to build a container release candidate at end of Monday. Do you think we can do that before then? If not, we can merge this and then remove when the updated lhotse is ready?

OK if it passes all tests, let's do it and remove later.

…-25.11

This reverts commit 73b79f3. Signed-off-by: Charlie Truong <chtruong@nvidia.com>

This reverts commit 8710db3. Signed-off-by: Charlie Truong <chtruong@nvidia.com>

Signed-off-by: chtruong814 <chtruong814@users.noreply.github.com>

github-actions · 2026-01-13T07:12:40Z

[🤖]: Hi @chtruong814 👋,

We wanted to let you know that a CICD pipeline for this PR just finished successfully.

So it might be time to merge this PR or get some approvals.

//cc @chtruong814 @ko3n1g @pablo-garay @thomasdhc

* Bump to pytorch 25.11 Signed-off-by: Charlie Truong <chtruong@nvidia.com> * Patch torch Sampler to expect data_source param for lhotse Signed-off-by: Charlie Truong <chtruong@nvidia.com> * Apply isort and black reformatting Signed-off-by: chtruong814 <chtruong814@users.noreply.github.com> * Skip broken asr onnx tests due to pytorch 25.11 update Signed-off-by: Charlie Truong <chtruong@nvidia.com> * Apply isort and black reformatting Signed-off-by: chtruong814 <chtruong814@users.noreply.github.com> * Only run speech tests for now Signed-off-by: Charlie Truong <chtruong@nvidia.com> * Fix speech CI Signed-off-by: Charlie Truong <chtruong@nvidia.com> * Revert "Fix speech CI" This reverts commit 8acdc2b. Signed-off-by: Charlie Truong <chtruong@nvidia.com> * Revert "Only run speech tests for now" This reverts commit bb3412e. Signed-off-by: Charlie Truong <chtruong@nvidia.com> * Revert "Apply isort and black reformatting" This reverts commit 73b79f3. Signed-off-by: Charlie Truong <chtruong@nvidia.com> * Revert "Skip broken asr onnx tests due to pytorch 25.11 update" This reverts commit 8710db3. Signed-off-by: Charlie Truong <chtruong@nvidia.com> * Apply isort and black reformatting Signed-off-by: chtruong814 <chtruong814@users.noreply.github.com> --------- Signed-off-by: Charlie Truong <chtruong@nvidia.com> Signed-off-by: chtruong814 <chtruong814@users.noreply.github.com> Co-authored-by: chtruong814 <chtruong814@users.noreply.github.com> Signed-off-by: Akhil Varanasi <akhilvaranasi23@gmail.com>

Bump to pytorch 25.11

e1800cd

Signed-off-by: Charlie Truong <chtruong@nvidia.com>

chtruong814 added the Run CICD label Jan 2, 2026

chtruong814 temporarily deployed to test January 2, 2026 15:48 — with GitHub Actions Inactive

github-actions bot removed the Run CICD label Jan 2, 2026

Patch torch Sampler to expect data_source param for lhotse

3a4c952

Signed-off-by: Charlie Truong <chtruong@nvidia.com>

github-actions bot added the common label Jan 6, 2026

chtruong814 added Run CICD and removed common labels Jan 6, 2026

Apply isort and black reformatting

73b79f3

Signed-off-by: chtruong814 <chtruong814@users.noreply.github.com>

github-actions bot added the common label Jan 6, 2026

chtruong814 added Run CICD and removed Run CICD labels Jan 6, 2026

github-actions bot removed the Run CICD label Jan 6, 2026

chtruong814 added skip-linting Run CICD labels Jan 6, 2026

chtruong814 temporarily deployed to test January 6, 2026 04:33 — with GitHub Actions Inactive

github-actions bot removed the Run CICD label Jan 6, 2026

Skip broken asr onnx tests due to pytorch 25.11 update

8710db3

Signed-off-by: Charlie Truong <chtruong@nvidia.com>

github-actions bot added the ASR label Jan 6, 2026

Apply isort and black reformatting

51e48ec

Signed-off-by: chtruong814 <chtruong814@users.noreply.github.com>

chtruong814 added Run CICD and removed ASR labels Jan 6, 2026

chtruong814 had a problem deploying to test January 6, 2026 18:44 — with GitHub Actions Error

Only run speech tests for now

bb3412e

Signed-off-by: Charlie Truong <chtruong@nvidia.com>

chtruong814 requested review from ko3n1g, pablo-garay and thomasdhc as code owners January 6, 2026 19:18

github-actions bot added ASR CI labels Jan 6, 2026

chtruong814 removed the Run CICD label Jan 6, 2026

chtruong814 added the Run CICD label Jan 6, 2026

Fix speech CI

8acdc2b

Signed-off-by: Charlie Truong <chtruong@nvidia.com>

chtruong814 added Run CICD and removed Run CICD labels Jan 6, 2026

chtruong814 temporarily deployed to test January 6, 2026 20:53 — with GitHub Actions Inactive

github-actions bot removed the Run CICD label Jan 7, 2026

chtruong814 added 2 commits January 7, 2026 09:10

Revert "Fix speech CI"

1bcb348

This reverts commit 8acdc2b. Signed-off-by: Charlie Truong <chtruong@nvidia.com>

Revert "Only run speech tests for now"

18e276d

This reverts commit bb3412e. Signed-off-by: Charlie Truong <chtruong@nvidia.com>

github-actions bot removed the CI label Jan 7, 2026

chtruong814 added the Run CICD label Jan 7, 2026

chtruong814 temporarily deployed to test January 7, 2026 15:13 — with GitHub Actions Inactive

github-actions bot removed the Run CICD label Jan 8, 2026

ko3n1g previously approved these changes Jan 9, 2026

View reviewed changes

nithinraok reviewed Jan 9, 2026

View reviewed changes

chtruong814 added 3 commits January 11, 2026 09:52

Merge remote-tracking branch 'origin/main' into chtruong/bump-pytorch…

efaf8a9

…-25.11

Revert "Apply isort and black reformatting"

d3c8d45

This reverts commit 73b79f3. Signed-off-by: Charlie Truong <chtruong@nvidia.com>

Revert "Skip broken asr onnx tests due to pytorch 25.11 update"

64582f8

This reverts commit 8710db3. Signed-off-by: Charlie Truong <chtruong@nvidia.com>

chtruong814 dismissed ko3n1g’s stale review via 64582f8 January 11, 2026 15:54

Apply isort and black reformatting

8749fa7

Signed-off-by: chtruong814 <chtruong814@users.noreply.github.com>

chtruong814 added the Run CICD label Jan 12, 2026

chtruong814 temporarily deployed to test January 12, 2026 17:09 — with GitHub Actions Inactive

pzelasko approved these changes Jan 12, 2026

View reviewed changes

nithinraok approved these changes Jan 12, 2026

View reviewed changes

github-actions bot removed the Run CICD label Jan 12, 2026

chtruong814 merged commit 77199b5 into main Jan 13, 2026
283 of 285 checks passed

chtruong814 deleted the chtruong/bump-pytorch-25.11 branch January 13, 2026 20:42

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Bump to pytorch 25.11#15247

Bump to pytorch 25.11#15247
chtruong814 merged 13 commits intomainfrom
chtruong/bump-pytorch-25.11

chtruong814 commented Jan 1, 2026

Uh oh!

github-actions bot commented Jan 7, 2026

Uh oh!

github-actions bot commented Jan 8, 2026

Uh oh!

nithinraok Jan 9, 2026

Uh oh!

pzelasko Jan 9, 2026

Uh oh!

chtruong814 Jan 9, 2026

Uh oh!

pzelasko Jan 12, 2026

Uh oh!

github-actions bot commented Jan 13, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

chtruong814 commented Jan 1, 2026

What does this PR do ?

Changelog

Usage

GitHub Actions CI

Before your PR is "Ready for review"

Who can review?

Additional Information

Uh oh!

github-actions bot commented Jan 7, 2026

Uh oh!

github-actions bot commented Jan 8, 2026

Uh oh!

nithinraok Jan 9, 2026

Choose a reason for hiding this comment

Uh oh!

pzelasko Jan 9, 2026

Choose a reason for hiding this comment

Uh oh!

chtruong814 Jan 9, 2026

Choose a reason for hiding this comment

Uh oh!

pzelasko Jan 12, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Jan 13, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants