Skip to content

Update conv_asr.py preventing unnecessary calculations#15239

Merged
blisc merged 3 commits intoNVIDIA-NeMo:mainfrom
tamilselvan0x0:patch-1
Jan 13, 2026
Merged

Update conv_asr.py preventing unnecessary calculations#15239
blisc merged 3 commits intoNVIDIA-NeMo:mainfrom
tamilselvan0x0:patch-1

Conversation

@tamilselvan0x0
Copy link
Contributor

@tamilselvan0x0 tamilselvan0x0 commented Dec 29, 2025

Important

The Update branch button must only be pressed in very rare occassions.
An outdated branch is never blocking the merge of a PR.
Please reach out to the automation team before pressing that button.

What does this PR do ?

Prevents unnecessory calculation

Changelog

In the forward function of SpeakerDecoder class, embeddings was calculated in a loop and added in a list at the end only last value of the list was used. I've updated it to run only for the last value and return it.

GitHub Actions CI

The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.

The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".

Before your PR is "Ready for review"

Pre checks:

  • Make sure you read and followed Contributor guidelines
  • Did you write any new necessary tests?
  • Did you add or update any necessary documentation?
  • Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
    • Reviewer: Does the PR have correct import guards for all optional libraries?

PR Type:

  • New Feature
  • Bugfix
  • Documentation

If you haven't finished some of the above items you can still open "Draft" PR.

Who can review?

Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.

@github-actions github-actions bot added the ASR label Dec 29, 2025
@tamilselvan0x0 tamilselvan0x0 changed the title Update conv_asr.py preventing unnessory calculations Update conv_asr.py preventing unnecessary calculations Dec 29, 2025
@blisc
Copy link
Collaborator

blisc commented Jan 13, 2026

Thanks for your contribution!

@blisc blisc merged commit a54be69 into NVIDIA-NeMo:main Jan 13, 2026
135 checks passed
@tamilselvan0x0 tamilselvan0x0 deleted the patch-1 branch January 14, 2026 06:00
AkCodes23 pushed a commit to AkCodes23/NeMo that referenced this pull request Jan 28, 2026
Signed-off-by: tamilselvan0X0 <[email protected]>
Co-authored-by: Jason <[email protected]>
Signed-off-by: Akhil Varanasi <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants